-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: use easyjson and context in regions interface (#6838) #6855
api: use easyjson and context in regions interface (#6838) #6855
Conversation
close tikv#6835 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: AndreMouche <AndreMouche@126.com>
@lhy1024 could you please take a look? |
@AndreMouche It is an enhancement, I think we should provide a hotfix rather than pick it to 6.5. |
Signed-off-by: lhy1024 <admin@liudos.us>
@AndreMouche I fix the conflict, but I am not sure whether pick it to other branches. cc @nolouch @niubell |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #6855 +/- ##
===============================================
- Coverage 75.59% 75.57% -0.03%
===============================================
Files 328 329 +1
Lines 33199 33595 +396
===============================================
+ Hits 25097 25389 +292
- Misses 5947 6028 +81
- Partials 2155 2178 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d8ac207
|
This is an automated cherry-pick of #6838
What problem does this PR solve?
Issue Number: Close #6835
What is changed and how does it work?
Check List
Tests
go test -benchmem -run=^$ -bench ^BenchmarkGetRegions$ github.com/tikv/pd/server/api -benchtime=30s
client:
curl -s -o /dev/null http://192.168.8.88:2379/pd/api/v1/regions
and ctrl-cserver: goroutine exit
Release note