Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: move scheduling-related config definitions into pkg #6857

Merged
merged 3 commits into from
Jul 28, 2023
Merged

*: move scheduling-related config definitions into pkg #6857

merged 3 commits into from
Jul 28, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Move scheduling-related config definitions into `pkg` to decouple the `server` dependency.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato
Move scheduling-related config definitions into pkg
218e0f1 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added component/schedule Scheduling logic. component/config Configuration logic. labels Jul 28, 2023
@JmPotato JmPotato requested review from lhy1024 and rleungx July 28, 2023 08:19
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2023
@JmPotato
Fix the swagger build
31541f9 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #6857 (6e029ea) into master (31343e0) will increase coverage by 0.00%.
The diff coverage is 84.33%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6857   +/-   ##
=======================================
  Coverage   74.12%   74.13%           
=======================================
  Files         415      417    +2     
  Lines       43926    43926           
=======================================
+ Hits        32562    32563    +1     
- Misses       8450     8457    +7     
+ Partials     2914     2906    -8
Flag Coverage Δ
unittests 74.13% <84.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JmPotato JmPotato mentioned this pull request Jul 28, 2023
Closed
rleungx
rleungx approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

pkg/schedule/coordinator.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2023
@JmPotato
Remove the unnecessary empty lines
6e029ea 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6e029ea

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit fe52361 into tikv:master Jul 28, 2023
@JmPotato JmPotato deleted the scheduling_conf_sync branch July 28, 2023 10:00
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@JmPotato @rleungx
*: move scheduling-related config definitions into pkg (tikv#6857)
c599e3e 
ref tikv#5839

Move scheduling-related config definitions into `pkg` to decouple the `server` dependency.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
component/config Configuration logic. component/schedule Scheduling logic. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @lhy1024 @rleungx