Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: merge hot stats #6891

Merged
merged 4 commits into from
Aug 7, 2023
Merged

*: merge hot stats #6891

merged 4 commits into from
Aug 7, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 3, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 3, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 August 3, 2023 07:47
@rleungx
merge hot stats
92abfc0 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #6891 (af8cfd8) into master (1faac0c) will decrease coverage by 0.03%.
The diff coverage is 93.91%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6891      +/-   ##
==========================================
- Coverage   74.16%   74.13%   -0.03%     
==========================================
  Files         428      427       -1     
  Lines       45121    45119       -2     
==========================================
- Hits        33463    33451      -12     
- Misses       8701     8708       +7     
- Partials     2957     2960       +3
Flag Coverage Δ
unittests 74.13% <93.91%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx mentioned this pull request Aug 3, 2023
Merged
@rleungx rleungx requested a review from bufferflies August 4, 2023 04:19
lhy1024
lhy1024 reviewed Aug 6, 2023
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

pkg/statistics/utils/constant.go Outdated
Comment on lines 22 to 25
// WriteReportInterval indicates the interval between write interval, the value is the heartbeat report interval of a region.
WriteReportInterval = 60
// ReadReportInterval indicates the interval between read stats report, the value is the heartbeat report interval of a store.
ReadReportInterval = 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about still using StoreHeartBeatReportInterval and RegionHeartBeatReportInterval?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean removing WriteReportInterval?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

pkg/statistics/utils/constant.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2023
@rleungx
rename
d9187cd 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx requested a review from lhy1024 August 7, 2023 02:27
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 7, 2023
@rleungx
Copy link
Member Author

rleungx commented Aug 7, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d9187cd

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8bc2311 into tikv:master Aug 7, 2023
@rleungx rleungx deleted the merge-hot branch August 7, 2023 04:02
@rleungx rleungx mentioned this pull request Aug 24, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx @ti-chi-bot
*: merge hot stats (tikv#6891)
f693bae 
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferflies bufferflies bufferflies approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @lhy1024 @bufferflies