-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slow node detection: enable evict-slow-trend
on raft-kv2
.
#6945
Conversation
This pr contains: + Enable `evict-slow-trend` scheduler on `raft-kv2` as default. + Opitimize the detection strategy on the perception of Network I/O delays on TiKV nodes. Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @LykxSassinator. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6945 +/- ##
==========================================
+ Coverage 74.23% 74.26% +0.02%
==========================================
Files 433 433
Lines 45860 45904 +44
==========================================
+ Hits 34046 34092 +46
- Misses 8802 8805 +3
+ Partials 3012 3007 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
/check-issue-triage-complete |
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
/cc @bufferflies PTAL, thx |
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
/test |
@LykxSassinator: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run test |
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: b29d736
|
/test build |
|
||
storeSlowTrendMiscGauge = prometheus.NewGaugeVec( | ||
prometheus.GaugeOpts{ | ||
Namespace: "pd", | ||
Subsystem: "scheduler", | ||
Name: "store_slow_trend_misc", | ||
Help: "Store trend internal uncatalogued values", | ||
}, []string{"type"}) | ||
Help: "Store trend internal uncatelogued values", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be uncatalogued
?
https://dictionary.cambridge.org/zhs/%E8%AF%8D%E5%85%B8/%E8%8B%B1%E8%AF%AD/uncatalogued
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's a spelling error. I'll tidy and clean up all misleading metrics in the next pr.
What problem does this PR solve?
Issue Number: Close #6868, Ref tikv/tikv#15271 and Close tikv/tikv#15267
What is changed and how does it work?
Records when building a cluster with
raft-kv-2
engine(multi-rocksdb):And we got the following metrics:
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note