Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add region stats to scheduling cluster #6985

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 24, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

The region heartbeat handling relies on the region stats and coordinator.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 24, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and Yisaer August 24, 2023 10:08
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2023
@rleungx rleungx requested review from JmPotato and lhy1024 and removed request for Yisaer and HunDunDM August 24, 2023 10:09
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #6985 (f179e8e) into master (50368e5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head f179e8e differs from pull request most recent head e46e90a. Consider uploading reports for the commit e46e90a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6985      +/-   ##
==========================================
+ Coverage   74.18%   74.23%   +0.04%     
==========================================
  Files         433      433              
  Lines       46133    46082      -51     
==========================================
- Hits        34225    34207      -18     
+ Misses       8887     8862      -25     
+ Partials     3021     3013       -8     
Flag Coverage Δ
unittests 74.23% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Member Author

rleungx commented Aug 25, 2023

@JmPotato PTAL

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 28, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e46e90a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6307aa8 into tikv:master Aug 28, 2023
22 checks passed
@rleungx rleungx deleted the region-stats branch August 28, 2023 05:36
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants