mcs: use separate participant #7032

rleungx · 2023-09-01T10:12:48Z

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Previously, we used tso participant for all micro-services which is not suitable. This PR distinguishes them by using different proto definitions.

Check List

Tests

Unit test

Release note

None.

ti-chi-bot · 2023-09-01T10:12:50Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-09-01T10:12:50Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

pkg/member/participant.go

rleungx · 2023-09-06T04:33:55Z

@lhy1024 PTAL

lhy1024 · 2023-09-06T05:52:02Z

pkg/member/participant.go

 	"github.com/tikv/pd/pkg/utils/etcdutil"
 	"go.etcd.io/etcd/clientv3"
 	"go.uber.org/zap"
 )

 type leadershipCheckFunc func(*election.Leadership) bool

+type participant interface {
+	GetName() string
+	GetId() uint64


How about GetID

No, it's generated by protobuf.

rleungx · 2023-09-06T06:27:06Z

/merge

ti-chi-bot · 2023-09-06T06:27:07Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-09-06T06:27:08Z

This pull request has been accepted and is ready to merge.

Commit hash: c1b8c3e

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx · 2023-09-06T06:37:06Z

/merge

ti-chi-bot · 2023-09-06T06:37:07Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-09-06T06:37:09Z

This pull request has been accepted and is ready to merge.

Commit hash: e9d730a

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx · 2023-09-06T07:41:50Z

/merge

ti-chi-bot · 2023-09-06T07:41:52Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-09-06T07:41:53Z

This pull request has been accepted and is ready to merge.

Commit hash: 69bf134

codecov · 2023-09-06T08:17:14Z

Codecov Report

Merging #7032 (ae2e070) into master (77d1998) will increase coverage by 0.01%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master    #7032      +/-   ##
==========================================
+ Coverage   74.38%   74.40%   +0.01%     
==========================================
  Files         436      436              
  Lines       46415    46437      +22     
==========================================
+ Hits        34527    34550      +23     
+ Misses       8868     8867       -1     
  Partials     3020     3020

Flag	Coverage Δ
unittests	`74.40% <96.29%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot bot requested review from lhy1024 and nolouch September 1, 2023 10:13

rleungx force-pushed the participant branch from ca9e3e6 to cd6e5da Compare September 4, 2023 03:22

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2023

rleungx force-pushed the participant branch from cd6e5da to 360715f Compare September 4, 2023 06:44

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Sep 4, 2023

rleungx marked this pull request as ready for review September 4, 2023 06:49

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2023

rleungx requested review from JmPotato and removed request for nolouch September 4, 2023 06:49

JmPotato approved these changes Sep 4, 2023

View reviewed changes

pkg/member/participant.go Show resolved Hide resolved

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 4, 2023

rleungx mentioned this pull request Sep 5, 2023

Use separate participant pingcap/kvproto#1180

Merged

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 5, 2023

rleungx force-pushed the participant branch from 6f11fef to c1b8c3e Compare September 6, 2023 02:48

JmPotato approved these changes Sep 6, 2023

View reviewed changes

lhy1024 approved these changes Sep 6, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023

rleungx added 2 commits September 6, 2023 14:32

use separate participant

ec81f46

Signed-off-by: Ryan Leung <rleungx@gmail.com>

update kvproto

e9d730a

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx force-pushed the participant branch from d7e0c51 to e9d730a Compare September 6, 2023 06:35

ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023

rleungx mentioned this pull request Sep 6, 2023

Separate scheduling into an independent service #5839

Closed

fix test

69bf134

Signed-off-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023

Merge branch 'master' into participant

ae2e070

ti-chi-bot bot merged commit a83322f into tikv:master Sep 6, 2023
22 checks passed

rleungx deleted the participant branch September 6, 2023 08:18

rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023

mcs: use separate participant (tikv#7032)

1a67217

ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mcs: use separate participant #7032

mcs: use separate participant #7032

rleungx commented Sep 1, 2023 •

edited

Loading

ti-chi-bot bot commented Sep 1, 2023 •

edited

Loading

ti-chi-bot bot commented Sep 1, 2023

rleungx commented Sep 6, 2023

lhy1024 Sep 6, 2023

rleungx Sep 6, 2023

rleungx commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

rleungx commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

rleungx commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

codecov bot commented Sep 6, 2023

mcs: use separate participant #7032

mcs: use separate participant #7032

Conversation

rleungx commented Sep 1, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Sep 1, 2023 • edited Loading

ti-chi-bot bot commented Sep 1, 2023

rleungx commented Sep 6, 2023

lhy1024 Sep 6, 2023

Choose a reason for hiding this comment

rleungx Sep 6, 2023

Choose a reason for hiding this comment

rleungx commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

rleungx commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

rleungx commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

codecov bot commented Sep 6, 2023

Codecov Report

rleungx commented Sep 1, 2023 •

edited

Loading

ti-chi-bot bot commented Sep 1, 2023 •

edited

Loading