Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: use memory storage #7061

Merged
merged 2 commits into from
Sep 11, 2023
Merged

mcs: use memory storage #7061

merged 2 commits into from
Sep 11, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 8, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 8, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2023
@rleungx rleungx requested review from JmPotato and lhy1024 and removed request for nolouch and HunDunDM September 8, 2023 09:26
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #7061 (7062bb9) into master (d031342) will increase coverage by 0.07%.
The diff coverage is 78.78%.

❗ Current head 7062bb9 differs from pull request most recent head fbbc765. Consider uploading reports for the commit fbbc765 to get more accurate results

@@            Coverage Diff             @@
##           master    #7061      +/-   ##
==========================================
+ Coverage   74.41%   74.48%   +0.07%     
==========================================
  Files         436      436              
  Lines       46440    46455      +15     
==========================================
+ Hits        34558    34602      +44     
+ Misses       8858     8832      -26     
+ Partials     3024     3021       -3
Flag Coverage Δ
unittests 74.48% <78.78%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

JmPotato
JmPotato reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

pkg/mcs/scheduling/server/cluster.go Outdated
Comment on lines 146 to 151
cli := c.apiServerLeader.Load()
if cli == nil {
c.checkMembershipCh <- struct{}{}
return 0, errors.New("API server leader is not found")
}
resp, err := cli.AllocID(c.ctx, &pdpb.AllocIDRequest{Header: &pdpb.RequestHeader{ClusterId: c.clusterID}})
resp, err := cli.(pdpb.PDClient).AllocID(c.ctx, &pdpb.AllocIDRequest{Header: &pdpb.RequestHeader{ClusterId: c.clusterID}})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract as a function c.GetAPIServerLeaderClient()?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2023
@rleungx
use memory storage
c154958 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
address the comment
fbbc765 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 11, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: fbbc765

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot merged commit 83369eb into tikv:master Sep 11, 2023
22 checks passed
@rleungx rleungx deleted the use-memory-storage branch September 11, 2023 07:00
@rleungx rleungx mentioned this pull request Sep 15, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
mcs: use memory storage (tikv#7061)
213c7e0 
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @JmPotato @lhy1024