Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: watch scheduling service's primary address #7072

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 11, 2023

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

The API server will watch the scheduling service's primary address for redirecting HTTP requests.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #7072 (31d5fb4) into master (2f57a9f) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 31d5fb4 differs from pull request most recent head f20acc9. Consider uploading reports for the commit f20acc9 to get more accurate results

@@            Coverage Diff             @@
##           master    #7072      +/-   ##
==========================================
+ Coverage   74.31%   74.44%   +0.12%     
==========================================
  Files         436      436              
  Lines       46479    46484       +5     
==========================================
+ Hits        34542    34604      +62     
+ Misses       8901     8841      -60     
- Partials     3036     3039       +3     
Flag Coverage Δ
unittests 74.44% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Member

rleungx commented Sep 11, 2023

Is it duplicated with #6976?

@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 11, 2023

Is it duplicated with #6976?

oh, yes, I missed #6976, but this PR uses less code and adds a test for watching.

server/server.go Outdated Show resolved Hide resolved
pkg/member/participant.go Outdated Show resolved Hide resolved
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 12, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 13, 2023

@JmPotato

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 31d5fb4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b8d9c6e into tikv:master Sep 13, 2023
19 checks passed
@lhy1024 lhy1024 deleted the sche-watcher branch September 13, 2023 04:27
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants