-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_control: watch delete with prev and refine test #7092
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
+ Coverage 74.31% 74.37% +0.05%
==========================================
Files 440 440
Lines 47217 47195 -22
==========================================
+ Hits 35088 35099 +11
+ Misses 9034 9016 -18
+ Partials 3095 3080 -15
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could u add a test?
And in client.go
there is also a implment of Watch Resource Group
.
PTAL, thx! |
d8304f2
to
c53357a
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
c53357a
to
58aecbb
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@nolouch friendly ping :) |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 06470c6
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#7095 Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Close #7095
What is changed and how does it work?
groupsController
is updated by watch channel, but we need to enable WithPrevKV to acquire delete value.That will result In when occurring delete action groupsController will not updated by watch channel
Check List
Tests
Release note