Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: disable plugin in default and persist file in specified dir (#7087) #7141

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7087

What problem does this PR solve?

Issue Number: Close #7094

What is changed and how does it work?

  • Load plugin and persist file in specified dir [config data dir]
  • Judge persist file name rather than delete this interface to keep compatible
  • Support a config to decide whether to enable the plugin

Check List

Tests

  • Unit test

Release note

Add compile configuration to enable `Load Plugin` and disable `Load Plugin` by default. Need to `make pd-server-plugin` when want to enable plugin

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 22, 2023
@HuSharp HuSharp force-pushed the cherry-pick-7087-to-release-6.5 branch 2 times, most recently from ed0c051 to 64b9676 Compare September 22, 2023 10:42
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 22, 2023
@HuSharp
Copy link
Member

HuSharp commented Sep 25, 2023

@nolouch @rleungx PTAL, thx!

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-7087-to-release-6.5 branch from 38414f7 to 1bdf29d Compare September 25, 2023 05:42
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage is 31.81% of modified lines.

Files Changed Coverage
server/api/admin.go ø
server/handler.go 0.00%
server/api/plugin_disable.go 20.00%
server/server.go 33.33%
server/util.go 42.85%
server/replication/replication_mode.go 100.00%

📢 Thoughts on this report? Let us know!.

@CabinfeverB
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a14c694

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 5b491e2 into tikv:release-6.5 Sep 25, 2023
18 of 19 checks passed
@HuSharp HuSharp deleted the cherry-pick-7087-to-release-6.5 branch September 25, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants