mcs: add service role #7175

rleungx · 2023-10-08T08:28:26Z

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

This PR changed the original role to table format and made other services' primary can be shown.

Check List

Tests

Manual test

New template in microservice mode:

New template in PD mode:

Release note

None.

ti-chi-bot · 2023-10-08T08:28:28Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-10-09T06:26:41Z

Codecov Report

Merging #7175 (13b2126) into master (2556b5b) will increase coverage by 0.01%.
The diff coverage is 77.77%.

❗ Current head 13b2126 differs from pull request most recent head 264b263. Consider uploading reports for the commit 264b263 to get more accurate results

@@            Coverage Diff             @@
##           master    #7175      +/-   ##
==========================================
+ Coverage   74.56%   74.58%   +0.01%     
==========================================
  Files         441      442       +1     
  Lines       47388    47398      +10     
==========================================
+ Hits        35335    35350      +15     
+ Misses       8957     8953       -4     
+ Partials     3096     3095       -1

Flag	Coverage Δ
unittests	`74.58% <77.77%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024

the rest LGTM

lhy1024 · 2023-10-09T06:39:10Z

pkg/mcs/resourcemanager/server/server.go

- versioninfo.Log("Resource Manager")
- log.Info("Resource Manager config", zap.Reflect("config", cfg))
+ versioninfo.Log(serviceName)
+ log.Info("Resource manager config", zap.Reflect("config", cfg))


Suggested change

log.Info("Resource manager config", zap.Reflect("config", cfg))

log.Info("resource manager config", zap.Reflect("config", cfg))

lhy1024 · 2023-10-09T06:40:13Z

pkg/mcs/scheduling/server/server.go

- versioninfo.Log("Scheduling")
- log.Info("Scheduling config", zap.Reflect("config", cfg))
+ versioninfo.Log(serviceName)
+ log.Info("Scheduling service config", zap.Reflect("config", cfg))


lhy1024 · 2023-10-09T06:40:19Z

pkg/mcs/tso/server/server.go

- versioninfo.Log("TSO")
- log.Info("TSO config", zap.Reflect("config", cfg))
+ versioninfo.Log(serviceName)
+ log.Info("TSO service config", zap.Reflect("config", cfg))


Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx · 2023-10-09T09:31:52Z

/merge

ti-chi-bot · 2023-10-09T09:31:54Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-10-09T09:31:56Z

This pull request has been accepted and is ready to merge.

Commit hash: 264b263

ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Oct 8, 2023

ti-chi-bot bot requested review from HunDunDM and lhy1024 October 8, 2023 08:28

ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 8, 2023

rleungx requested review from JmPotato and removed request for HunDunDM October 8, 2023 08:29

rleungx force-pushed the role branch from 73b1dde to b271b7e Compare October 8, 2023 08:34

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Oct 8, 2023

rleungx force-pushed the role branch from b271b7e to 3345aaf Compare October 8, 2023 09:09

rleungx mentioned this pull request Oct 8, 2023

Separate scheduling into an independent service #5839

Closed

JmPotato approved these changes Oct 9, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2023

lhy1024 reviewed Oct 9, 2023

View reviewed changes

rleungx added 2 commits October 9, 2023 14:45

add service role

ae72ada

Signed-off-by: Ryan Leung <rleungx@gmail.com>

change to lower case

13b2126

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx force-pushed the role branch from 1ced9ca to 13b2126 Compare October 9, 2023 06:52

lhy1024 approved these changes Oct 9, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2023

rleungx force-pushed the role branch from 77a61b9 to 13b2126 Compare October 9, 2023 07:07

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 9, 2023

cleanup

264b263

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx force-pushed the role branch from d4b00b8 to 264b263 Compare October 9, 2023 09:27

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2023

ti-chi-bot bot merged commit 097f25a into tikv:master Oct 9, 2023
22 checks passed

rleungx deleted the role branch October 9, 2023 09:40

rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023

mcs: add service role (tikv#7175)

5928a0d

ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mcs: add service role #7175

mcs: add service role #7175

rleungx commented Oct 8, 2023 •

edited

Loading

ti-chi-bot bot commented Oct 8, 2023 •

edited

Loading

codecov bot commented Oct 9, 2023 •

edited

Loading

lhy1024 left a comment

lhy1024 Oct 9, 2023

lhy1024 Oct 9, 2023

lhy1024 Oct 9, 2023

rleungx commented Oct 9, 2023

ti-chi-bot bot commented Oct 9, 2023

ti-chi-bot bot commented Oct 9, 2023

	log.Info("Resource manager config", zap.Reflect("config", cfg))
	log.Info("resource manager config", zap.Reflect("config", cfg))

mcs: add service role #7175

mcs: add service role #7175

Conversation

rleungx commented Oct 8, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Oct 8, 2023 • edited Loading

codecov bot commented Oct 9, 2023 • edited Loading

Codecov Report

lhy1024 left a comment

Choose a reason for hiding this comment

lhy1024 Oct 9, 2023

Choose a reason for hiding this comment

lhy1024 Oct 9, 2023

Choose a reason for hiding this comment

lhy1024 Oct 9, 2023

Choose a reason for hiding this comment

rleungx commented Oct 9, 2023

ti-chi-bot bot commented Oct 9, 2023

ti-chi-bot bot commented Oct 9, 2023

rleungx commented Oct 8, 2023 •

edited

Loading

ti-chi-bot bot commented Oct 8, 2023 •

edited

Loading

codecov bot commented Oct 9, 2023 •

edited

Loading