mcs: fix panic of forwarding request #7220
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #7220 +/- ##
==========================================
- Coverage 74.65% 74.43% -0.22%
==========================================
Files 442 442
Lines 47744 47910 +166
==========================================
+ Hits 35642 35662 +20
- Misses 8957 9089 +132
- Partials 3145 3159 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -1002,16 +1003,16 @@ func (s *GrpcServer) StoreHeartbeat(ctx context.Context, request *pdpb.StoreHear | |||
| s.handleDamagedStore(request.GetStats()) | |||
| storeHeartbeatHandleDuration.WithLabelValues(storeAddress, storeLabel).Observe(time.Since(start).Seconds()) | |||
| if s.IsAPIServiceMode() { | |||
| s.updateSchedulingClient(ctx) | |||
| if s.schedulingClient.Load() != nil { | |||
| forwardCli, _ := s.updateSchedulingClient(ctx) | |||
There was a problem hiding this comment.
Will the ignored error be a problem?
There was a problem hiding this comment.
In this situation, the primary is not ready. To avoid it affect the normal heartbeat, I just skip it.
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 1f5ea4b
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
Fix the panic when the scheduling service doesn't have the primary.
Check List
Tests
Release note