Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator, mcs/scheduling: fix the default schedulers initialization #7236

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #7169.

What is changed and how does it work?

Fix the default scheduler initialization of the scheduling service.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/schedule Scheduling logic. component/mcs Microservice. labels Oct 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #7236 (5359c9c) into master (8b2896b) will decrease coverage by 0.25%.
Report is 6 commits behind head on master.
The diff coverage is 37.60%.

@@            Coverage Diff             @@
##           master    #7236      +/-   ##
==========================================
- Coverage   74.65%   74.40%   -0.25%     
==========================================
  Files         442      442              
  Lines       47744    48026     +282     
==========================================
+ Hits        35642    35733      +91     
- Misses       8957     9139     +182     
- Partials     3145     3154       +9     
Flag Coverage Δ
unittests 74.40% <37.60%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 5359c9c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 43551e2 into tikv:master Oct 20, 2023
24 of 26 checks passed
@JmPotato JmPotato deleted the fix_default_schedulers_init branch October 20, 2023 06:20
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
tikv#7236)

close tikv#7169

Fix the default scheduler initialization of the scheduling service.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mcs Microservice. component/schedule Scheduling logic. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mcs: deleted scheduler is not synced to scheduling server
3 participants