Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add timeout when call alloc of api server #7254

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 25, 2023

What problem does this PR solve?

Issue Number: Close #7207

If scheduling server calls alloc in patrolChecker while destroy cluster, but api server has been closed, scheduling server will always stuck and cannot be closed.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #7254 (dc749e7) into master (1899f41) will increase coverage by 0.05%.
Report is 3 commits behind head on master.
The diff coverage is 44.26%.

@@            Coverage Diff             @@
##           master    #7254      +/-   ##
==========================================
+ Coverage   74.35%   74.41%   +0.05%     
==========================================
  Files         446      446              
  Lines       48159    48200      +41     
==========================================
+ Hits        35810    35869      +59     
+ Misses       9191     9176      -15     
+ Partials     3158     3155       -3     
Flag Coverage Δ
unittests 74.41% <44.26%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 26, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: dc749e7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 459671f into tikv:master Oct 26, 2023
24 of 27 checks passed
@lhy1024 lhy1024 deleted the fix-mcs branch October 26, 2023 10:50
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7207

Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestHotTestSuite is unstable
3 participants