mcs: support config http interface in scheduling server #7278

lhy1024 · 2023-10-26T16:00:41Z

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot · 2023-10-26T16:00:44Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-10-26T16:00:44Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

server/api/config.go

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2023-11-01T13:24:54Z

server/api/config.go

+		}
+		cfg.Schedule = configSchedulingServer.Schedule
+		cfg.Replication = configSchedulingServer.Replication
+		// TODO: will we support config/store?


TODO: will we support config/store?

lhy1024 · 2023-11-01T13:26:48Z

tests/server/config/config_test.go

+func (suite *configTestSuite) TestConfigTTL() {
+	env := tests.NewSchedulingTestEnvironment(suite.T())
+	// FIXME: enable this test in two modes after ttl config is supported.
+	env.RunTestInPDMode(suite.checkConfigTTL)


lhy1024 · 2023-11-01T13:26:58Z

tests/server/config/config_test.go

+
+func (suite *configTestSuite) TestTTLConflict() {
+	env := tests.NewSchedulingTestEnvironment(suite.T())
+	// FIXME: enable this test in two modes after ttl config is supported.


codecov · 2023-11-01T14:39:30Z

Codecov Report

Merging #7278 (b8f59a1) into master (c332ddc) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 62.68%.

❗ Current head b8f59a1 differs from pull request most recent head 860ea5c. Consider uploading reports for the commit 860ea5c to get more accurate results

@@            Coverage Diff             @@
##           master    #7278      +/-   ##
==========================================
- Coverage   74.38%   74.34%   -0.05%     
==========================================
  Files         446      446              
  Lines       48352    48418      +66     
==========================================
+ Hits        35969    35998      +29     
- Misses       9198     9221      +23     
- Partials     3185     3199      +14

Flag	Coverage Δ
unittests	`74.34% <62.68%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx · 2023-11-02T04:02:36Z

pkg/mcs/scheduling/server/apis/v1/api.go

+	router.GET("/schedule", getScheduleConfig)
+	router.GET("/replicate", getReplicationConfig)
+	router.GET("/store", getStoreConfig)


I was wondering if we need these APIs, I think they are barely used.

Because api server has the same interface. Maybe we also call "/config" in api server for these interfaces?

I think it's better, WDYT?

I think we can cancel "/config/schedule" and "/config/replicate", which are in "/config". But we should keep "config/store", otherwise we have no way to get store config, which is not in "/config".

Or we can put store config into "/config" and add a new struct for it. How about it?

type ConfigPayload{ Schedule Replication StoreConfig ... }

OK, make sense to me.

Or only remove "/config/store", I found there is no "/config/store" in api server

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2023-11-07T02:58:59Z

/merge

ti-chi-bot · 2023-11-07T02:59:02Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-07T02:59:03Z

This pull request has been accepted and is ready to merge.

Commit hash: adc7879

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2023-11-07T06:19:39Z

/merge

ti-chi-bot · 2023-11-07T06:19:41Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-07T06:19:43Z

This pull request has been accepted and is ready to merge.

Commit hash: b8f59a1

ref tikv#5839 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

mcs: support config http interface in scheduling server

cbdae92

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 26, 2023

ti-chi-bot bot requested review from JmPotato and rleungx October 26, 2023 16:00

ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 26, 2023

lhy1024 mentioned this pull request Oct 27, 2023

mcs: forward request to scheduling server #7178

Closed

25 tasks

rleungx reviewed Oct 27, 2023

View reviewed changes

server/api/config.go Outdated Show resolved Hide resolved

Merge branch 'master' of github.com:tikv/pd into sche-redirect9

08927e5

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2023

lhy1024 commented Nov 1, 2023

View reviewed changes

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2023

lhy1024 commented Nov 1, 2023

View reviewed changes

lhy1024 marked this pull request as ready for review November 1, 2023 13:27

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023

move and fix test

bd12406

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the sche-redirect9 branch from 7eb4b10 to bd12406 Compare November 1, 2023 14:52

add more test

4baba6d

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 mentioned this pull request Nov 2, 2023

mcs: support to sync config with ttl #7296

Closed

make test stable

e3bf609

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx reviewed Nov 2, 2023

View reviewed changes

lhy1024 added 3 commits November 2, 2023 14:40

remove uncommon interfaces

d6c89cd

Signed-off-by: lhy1024 <admin@liudos.us>

fix

ab8bc53

Signed-off-by: lhy1024 <admin@liudos.us>

fix lint

ab06849

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 requested a review from rleungx November 2, 2023 07:09

lhy1024 added 2 commits November 2, 2023 20:37

make test stable

41f35c2

Signed-off-by: lhy1024 <admin@liudos.us>

add more test

adc7879

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx approved these changes Nov 3, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2023

JmPotato approved these changes Nov 3, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 3, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2023

ti-chi-bot bot and others added 2 commits November 7, 2023 02:59

Merge branch 'master' into sche-redirect9

5261c00

fix test

b8f59a1

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2023

Merge branch 'master' into sche-redirect9

860ea5c

ti-chi-bot bot merged commit 47ba96f into tikv:master Nov 7, 2023
22 checks passed

rleungx mentioned this pull request Nov 30, 2023

Separate scheduling into an independent service #5839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mcs: support config http interface in scheduling server #7278

mcs: support config http interface in scheduling server #7278

lhy1024 commented Oct 26, 2023

ti-chi-bot bot commented Oct 26, 2023 •

edited

Loading

ti-chi-bot bot commented Oct 26, 2023

lhy1024 Nov 1, 2023

lhy1024 Nov 1, 2023

lhy1024 Nov 1, 2023

codecov bot commented Nov 1, 2023 •

edited

Loading

rleungx Nov 2, 2023

lhy1024 Nov 2, 2023

rleungx Nov 2, 2023

lhy1024 Nov 2, 2023

lhy1024 Nov 2, 2023

rleungx Nov 2, 2023

lhy1024 Nov 2, 2023

lhy1024 commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

lhy1024 commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

mcs: support config http interface in scheduling server #7278

mcs: support config http interface in scheduling server #7278

Conversation

lhy1024 commented Oct 26, 2023

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Oct 26, 2023 • edited Loading

ti-chi-bot bot commented Oct 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 1, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lhy1024 commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

lhy1024 commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

ti-chi-bot bot commented Nov 7, 2023

ti-chi-bot bot commented Oct 26, 2023 •

edited

Loading

codecov bot commented Nov 1, 2023 •

edited

Loading