Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: support admin/cache http interface in scheduling server #7279

Merged
merged 5 commits into from
Oct 30, 2023
Merged

mcs: support admin/cache http interface in scheduling server #7279

merged 5 commits into from
Oct 30, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 26, 2023

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
mcs: support admin/cache http interface in scheduling server
dc3e9ac 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 26, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx October 26, 2023 16:02
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #7279 (8d4c72d) into master (744e51d) will increase coverage by 0.00%.
The diff coverage is 59.32%.

❗ Current head 8d4c72d differs from pull request most recent head 0cc98c4. Consider uploading reports for the commit 0cc98c4 to get more accurate results

@@           Coverage Diff           @@
##           master    #7279   +/-   ##
=======================================
  Coverage   74.40%   74.41%           
=======================================
  Files         446      446           
  Lines       48229    48284   +55     
=======================================
+ Hits        35886    35931   +45     
- Misses       9181     9188    +7     
- Partials     3162     3165    +3
Flag Coverage Δ
unittests 74.41% <59.32%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Oct 27, 2023
View reviewed changes
pkg/mcs/scheduling/server/apis/v1/api.go Outdated
@@ -121,6 +121,9 @@ func NewService(srv *scheserver.Service) *Service {
func (s *Service) RegisterAdminRouter() {
router := s.root.Group("admin")
router.PUT("/log", changeLogLevel)
cacheRouter := router.Group("cache/regions")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about only cache or just not create a new group?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean cacheRouter := s.root.Group("admin/cache/regions")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cacheRouter := s.root.Group("cache") or just use router.DELETE("cache/regions", xxx)

@lhy1024 lhy1024 mentioned this pull request Oct 27, 2023
Closed
25 tasks
@lhy1024 lhy1024 requested review from rleungx and JmPotato and removed request for HunDunDM October 30, 2023 03:04
@lhy1024
address comments
8d4c72d 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 30, 2023
@lhy1024
address comments
0cc98c4 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 30, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 30, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0cc98c4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit ce0bb5d into tikv:master Oct 30, 2023
22 checks passed
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@lhy1024 @rleungx
mcs: support admin/cache http interface in scheduling server (tikv#7279)
8e9cf1f 
ref tikv#5839

Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhy1024 @nolouch @rleungx