-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: fix duplicated metrics #7319
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/check-issue-triage-complete |
Codecov Report
@@ Coverage Diff @@
## master #7319 +/- ##
==========================================
- Coverage 74.52% 74.35% -0.17%
==========================================
Files 446 446
Lines 48346 48346
==========================================
- Hits 36030 35950 -80
- Misses 9146 9206 +60
- Partials 3170 3190 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f754ae1
|
close tikv#7290 Signed-off-by: Ryan Leung <rleungx@gmail.com>
What problem does this PR solve?
Issue Number: Close #7290.
What is changed and how does it work?
This PR moves redirector after root group init so that the metrics request won't be redirected to the primary.
Check List
Tests
tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 2 --kv 3 --tiflash 0 --host 10.2.8.101
Release note