Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: fix duplicated metrics #7319

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 3, 2023

What problem does this PR solve?

Issue Number: Close #7290.

What is changed and how does it work?

This PR moves redirector after root group init so that the metrics request won't be redirected to the primary.

Check List

Tests

  • Manual test

tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 2 --kv 3 --tiflash 0 --host 10.2.8.101

Screenshot 2023-11-03 at 18 16 16

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2023
@rleungx rleungx requested review from lhy1024 and removed request for disksing November 3, 2023 10:22
@rleungx
Copy link
Member Author

rleungx commented Nov 3, 2023

/check-issue-triage-complete

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #7319 (f754ae1) into master (689fcbe) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7319      +/-   ##
==========================================
- Coverage   74.52%   74.35%   -0.17%     
==========================================
  Files         446      446              
  Lines       48346    48346              
==========================================
- Hits        36030    35950      -80     
- Misses       9146     9206      +60     
- Partials     3170     3190      +20     
Flag Coverage Δ
unittests 74.35% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 3, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 6, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f754ae1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit ab8bf7b into tikv:master Nov 6, 2023
27 checks passed
@rleungx rleungx deleted the fix-duplicated-metrics branch November 6, 2023 02:16
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7290

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Primary metrics is duplicated
3 participants