Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: refine the interval of scheduling tick in evict-slow-trend-scheduler. #7326

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Nov 7, 2023

What problem does this PR solve?

Issue Number: Ref #7156

What is changed and how does it work?

Implement the `GetNextInterval` for `evict-slow-trend-scheduler`, to refine the ticking interval.

Default `GetNextInterval` is not appropriate for `evict-slow-trend-scheduler`, as it might delay
the checking of other nodes' slowness status.

This pr adjusts the ticking interval of the evict-slow-trend-scheduler to optimize
its behavior. If a slow node is already identified as a candidate, the next
interval is now set to be shorter, ensuring quicker subsequent scheduling. 
This refinement aims to decrease response time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 7, 2023
@ti-chi-bot ti-chi-bot bot requested review from rleungx and Yisaer November 7, 2023 05:58
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #7326 (66b32c8) into master (f1cee6c) will decrease coverage by 0.05%.
The diff coverage is 62.50%.

❗ Current head 66b32c8 differs from pull request most recent head 5f8c2ce. Consider uploading reports for the commit 5f8c2ce to get more accurate results

@@            Coverage Diff             @@
##           master    #7326      +/-   ##
==========================================
- Coverage   74.48%   74.44%   -0.05%     
==========================================
  Files         446      446              
  Lines       48451    48448       -3     
==========================================
- Hits        36090    36066      -24     
- Misses       9174     9189      +15     
- Partials     3187     3193       +6     
Flag Coverage Δ
unittests 74.44% <62.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@LykxSassinator
Copy link
Contributor Author

/cc @bufferflies

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2023
@rleungx
Copy link
Member

rleungx commented Nov 10, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 66b32c8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

@LykxSassinator: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b5119ea into tikv:master Nov 10, 2023
22 checks passed
@LykxSassinator LykxSassinator deleted the polish_slow_trend branch November 10, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants