Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: fix participant name #7335

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 8, 2023

What problem does this PR solve?

Issue Number: Close #7336.

What is changed and how does it work?

Previously, in operator env, the primary name used the listen address which could be duplicated.

[2023/11/07 11:14:20.525 +00:00] [INFO] [server.go:267] ["campaign scheduling primary ok"] [campaign-scheduling-primary-name=http://0.0.0.0:2379]

Check List

Tests

  • Manual test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 November 8, 2023 03:43
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Nov 8, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-triage-completed labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #7335 (c20da40) into master (4457ac2) will increase coverage by 0.04%.
The diff coverage is 57.14%.

❗ Current head c20da40 differs from pull request most recent head 0e5fa13. Consider uploading reports for the commit 0e5fa13 to get more accurate results

@@            Coverage Diff             @@
##           master    #7335      +/-   ##
==========================================
+ Coverage   74.42%   74.46%   +0.04%     
==========================================
  Files         446      446              
  Lines       48433    48440       +7     
==========================================
+ Hits        36047    36072      +25     
+ Misses       9200     9185      -15     
+ Partials     3186     3183       -3     
Flag Coverage Δ
unittests 74.46% <57.14%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 8, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c20da40

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit a98295c into tikv:master Nov 8, 2023
22 checks passed
@rleungx rleungx deleted the fix-participant-name branch November 8, 2023 08:25
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7336

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two scheduling service primary when deploy with spliting service
3 participants