Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add rule middleware #7357

Merged
merged 2 commits into from
Nov 13, 2023
Merged

api: add rule middleware #7357

merged 2 commits into from
Nov 13, 2023

Conversation

CabinfeverB
Copy link
Member

@CabinfeverB CabinfeverB commented Nov 10, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5839

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@CabinfeverB
add rule middleware
9009056 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Nov 10, 2023
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx November 10, 2023 15:44
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 10, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

Merging #7357 (31c536e) into master (1a0233b) will increase coverage by 0.05%.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##           master    #7357      +/-   ##
==========================================
+ Coverage   74.48%   74.54%   +0.05%     
==========================================
  Files         447      447              
  Lines       48756    48666      -90     
==========================================
- Hits        36318    36277      -41     
+ Misses       9223     9190      -33     
+ Partials     3215     3199      -16
Flag Coverage Δ
unittests 74.54% <94.64%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024
lhy1024 reviewed Nov 13, 2023
View reviewed changes
server/api/rule.go
}
}

func (m ruleMiddleware) Middleware(h http.Handler) http.Handler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we support it in scheduling server?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduling server uses gin and does implement this in Handler. So i think we don't need to use middleware in scheduling server now.

rleungx
rleungx reviewed Nov 13, 2023
View reviewed changes
server/api/rule.go
*server.Handler
}

func newRuleMiddleware(s *server.Server, rd *render.Render) ruleMiddleware {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move it to middleware.go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is only used in rulesHander, I put it in rules.go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are ok to me.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 13, 2023
@rleungx
Copy link
Member

rleungx commented Nov 13, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9009056

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit e6e35fd into tikv:master Nov 13, 2023
23 checks passed
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@CabinfeverB @ti-chi-bot @rleungx
api: add rule middleware (tikv#7357)
186c815 
ref tikv#5839

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CabinfeverB @rleungx @lhy1024