Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make TestUpdateAfterResetTSO stable #7385

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 16, 2023

What problem does this PR solve?

Issue Number: Close #7381

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Manual test
for i in {1..100}
do
	go test -timeout 120s -run ^TestMicroserviceTSOClient$ github.com/tikv/pd/tests/integrations/tso
	go clean -testcache
done

image

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7385 (09e89bb) into master (a6800a9) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 09e89bb differs from pull request most recent head 68a03c2. Consider uploading reports for the commit 68a03c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7385      +/-   ##
==========================================
- Coverage   74.34%   74.24%   -0.11%     
==========================================
  Files         451      451              
  Lines       48897    48888       -9     
==========================================
- Hits        36352    36296      -56     
- Misses       9327     9377      +50     
+ Partials     3218     3215       -3     
Flag Coverage Δ
unittests 74.24% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024 lhy1024 requested a review from HuSharp November 16, 2023 08:48
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 16, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 09e89bb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit f2eaf23 into tikv:master Nov 16, 2023
22 checks passed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7381

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
HuSharp added a commit to ti-chi-bot/pd that referenced this pull request Feb 2, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp added a commit to HuSharp/pd that referenced this pull request Feb 2, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestMicroserviceTSOClient/TestUpdateAfterResetTSO is unstable
3 participants