Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: remove stale client endpoints for healthyChecker (#7227) #7387

Closed

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 16, 2023

This is an automated cherry-pick of #7227

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: Close #7226

What has changed and how does it work?

Remove the stale client endpoints in the healthyChecker.update for every 10s.

remove stale client endpoints for `healthyChecker`

has been cp by #7793

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and Yisaer November 16, 2023 09:43
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7387 (b57985f) into release-7.5 (d0a17ca) will decrease coverage by 0.01%.
Report is 15 commits behind head on release-7.5.
The diff coverage is 85.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7387      +/-   ##
===============================================
- Coverage        74.61%   74.61%   -0.01%     
===============================================
  Files              442      442              
  Lines            47822    47834      +12     
===============================================
+ Hits             35682    35690       +8     
- Misses            8985     8986       +1     
- Partials          3155     3158       +3     
Flag Coverage Δ
unittests 74.61% <85.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/cherry-pick-not-approved labels Feb 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Member

HuSharp commented Feb 4, 2024

cp by #7793

@HuSharp HuSharp closed this Feb 4, 2024
@HuSharp HuSharp deleted the cherry-pick-7227-to-release-7.5 branch February 4, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants