-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: make TestFallbackTSOConsistency stable #7408
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use testutil.Eventually
?
@@ -27,7 +27,7 @@ import ( | |||
tso "github.com/tikv/pd/pkg/mcs/tso/server" | |||
tsopkg "github.com/tikv/pd/pkg/tso" | |||
"github.com/tikv/pd/pkg/utils/tempurl" | |||
pd "github.com/tikv/pd/pkg/utils/testutil" | |||
tu "github.com/tikv/pd/pkg/utils/testutil" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use the original package name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most places, it is called tu
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7408 +/- ##
==========================================
- Coverage 74.28% 74.25% -0.04%
==========================================
Files 451 451
Lines 49174 49174
==========================================
- Hits 36527 36512 -15
- Misses 9423 9429 +6
- Partials 3224 3233 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 0afb184
|
close tikv#7407 Signed-off-by: lhy1024 <admin@liudos.us>
What problem does this PR solve?
Issue Number: Close #7407
What is changed and how does it work?
Check List
Tests
Release note