Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make TestPrimaryChange stable #7412

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 22, 2023

What problem does this PR solve?

Issue Number: Close #7237.

What is changed and how does it work?

After the server starts, there will be a time window before starting schedulers.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 22, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #7412 (ae88c29) into master (20da1c7) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7412      +/-   ##
==========================================
- Coverage   74.28%   74.17%   -0.12%     
==========================================
  Files         451      451              
  Lines       49174    49174              
==========================================
- Hits        36528    36473      -55     
- Misses       9417     9461      +44     
- Partials     3229     3240      +11     
Flag Coverage Δ
unittests 74.17% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 22, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 22, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ae88c29

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2023
@rleungx rleungx merged commit 7783c74 into tikv:master Nov 22, 2023
27 checks passed
@rleungx rleungx deleted the stable-test12 branch November 22, 2023 07:33
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestPrimaryChange is failed
2 participants