Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix data race when starting server #7420

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 23, 2023

What problem does this PR solve?

Issue Number: Close #7419.

What is changed and how does it work?

Because etcd is started first, before the server is started, the incoming request may cause a data race since the member is not initialized.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Nov 23, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #7420 (ca42385) into master (c0dad35) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head ca42385 differs from pull request most recent head 45cefa7. Consider uploading reports for the commit 45cefa7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7420      +/-   ##
==========================================
+ Coverage   74.25%   74.31%   +0.05%     
==========================================
  Files         451      451              
  Lines       49386    49385       -1     
==========================================
+ Hits        36671    36699      +28     
+ Misses       9453     9426      -27     
+ Partials     3262     3260       -2     
Flag Coverage Δ
unittests 74.31% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Member Author

rleungx commented Nov 23, 2023

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 23, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ca42385

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 8198735 into tikv:master Nov 23, 2023
22 checks passed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7419

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race when starting server
3 participants