Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: reduce mcs test duration #7435

Merged
merged 16 commits into from
Dec 8, 2023
Merged

tests: reduce mcs test duration #7435

merged 16 commits into from
Dec 8, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

test before after
github.com/tikv/pd/tests/pdctl/scheduler 45.635s 38.585s
github.com/tikv/pd/tests/pdctl/config 73.593s 26.162s
github.com/tikv/pd/tests/server/api 449.251s 287.441s
github.com/tikv/pd/tests/pdctl/hot 40.186s 19.539s
github.com/tikv/pd/tests/integrations/mcs/scheduling 161.653s 61.049s
github.com/tikv/pd/tests/server/config 110.405s 37.199s

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
tests: reduce mcs test duration
7e91eda 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 24, 2023
@lhy1024
stable test
e46e1b4 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
fix leak
018cf3f 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 marked this pull request as draft November 25, 2023 15:49
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2023
@lhy1024
update
eb0b77a 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Merge branch 'master' of github.com:tikv/pd into reduce-test-time
133f79d 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 27, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Merging #7435 (3729fa8) into master (995fcef) will increase coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 97.10%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7435      +/-   ##
==========================================
+ Coverage   74.46%   74.50%   +0.03%     
==========================================
  Files         452      452              
  Lines       49942    49966      +24     
==========================================
+ Hits        37190    37225      +35     
+ Misses       9412     9407       -5     
+ Partials     3340     3334       -6
Flag Coverage Δ
unittests 74.50% <97.10%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024 lhy1024 marked this pull request as ready for review November 28, 2023 05:48
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@lhy1024 lhy1024 requested review from CabinfeverB and removed request for disksing November 28, 2023 05:48
@rleungx
Copy link
Member

rleungx commented Nov 29, 2023

Please update the result after this PR.

@lhy1024
Merge branch 'master' of github.com:tikv/pd into reduce-test-time
cf860e0 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
fix test
43b40dc 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
make test stable
9a732b6 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
make test stable
a2783a5 
Signed-off-by: lhy1024 <admin@liudos.us>
rleungx
rleungx reviewed Nov 30, 2023
View reviewed changes
tests/server/api/rule_test.go
env := tests.NewSchedulingTestEnvironment(suite.T(), opts...)
env.RunTestInTwoModes(suite.checkGetAllByKey)
// Fixme: after delete+set rule, the key range will be empty, so the test will fail in api mode.
suite.env.RunTestInPDMode(suite.checkGetAllByKey)
Copy link
Member

@rleungx rleungx Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it failed every time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it will failed in api mode.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2023
@lhy1024
chmod
0394f8e 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Merge branch 'master' of github.com:tikv/pd into reduce-test-time
977d86a 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
use in other test
12da5f4 
Signed-off-by: lhy1024 <admin@liudos.us>
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
nolouch
nolouch approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2023
@nolouch
Copy link
Contributor

nolouch commented Dec 8, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 12da5f4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit ab3025c into tikv:master Dec 8, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@rleungx rleungx rleungx approved these changes

@CabinfeverB CabinfeverB Awaiting requested review from CabinfeverB

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhy1024 @rleungx @nolouch