Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/http: add GetHistoryHotRegions interface and more tests #7453

Merged
merged 4 commits into from
Nov 29, 2023
Merged

client/http: add GetHistoryHotRegions interface and more tests #7453

merged 4 commits into from
Nov 29, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7300.

What is changed and how does it work?

- Add `GetHistoryHotRegions` interface.
- Add more tests.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/api HTTP API. component/client Client logic. labels Nov 27, 2023
@JmPotato JmPotato requested review from rleungx and HuSharp November 27, 2023 09:17
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 27, 2023
@JmPotato JmPotato mentioned this pull request Nov 27, 2023
Open
7 tasks
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Merging #7453 (0f59856) into master (4356aeb) will increase coverage by 0.20%.
The diff coverage is 71.42%.

❗ Current head 0f59856 differs from pull request most recent head 3d7e391. Consider uploading reports for the commit 3d7e391 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7453      +/-   ##
==========================================
+ Coverage   74.16%   74.36%   +0.20%     
==========================================
  Files         451      451              
  Lines       49697    49714      +17     
==========================================
+ Hits        36856    36970     +114     
+ Misses       9521     9422      -99     
- Partials     3320     3322       +2
Flag Coverage Δ
unittests 74.36% <71.42%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Nov 28, 2023
View reviewed changes
client/http/client.go Outdated Show resolved Hide resolved
CabinfeverB
CabinfeverB reviewed Nov 28, 2023
View reviewed changes
client/http/client.go Outdated Show resolved Hide resolved
@JmPotato
Add GetHistoryHotRegions interface and more tests
fc17587 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the add_meta_http_client_test branch from 27a4a36 to f62d10c Compare November 28, 2023 07:16
@JmPotato
Address the comment
d961677 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the add_meta_http_client_test branch from f62d10c to d961677 Compare November 28, 2023 07:17
@JmPotato
Add TestScheduleConfig
0f59856 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
HuSharp
HuSharp reviewed Nov 29, 2023
View reviewed changes
client/http/client.go
// WithAllowFollowerHandle sets the header field to allow a PD follower to handle this request.
func WithAllowFollowerHandle() HeaderOption {
return func(header http.Header) {
header.Set("PD-Allow-Follower-Handle", "true")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use const for PD-Allow-Follower-Handle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is only one constant right now, I think we can change it later when we introduce more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3d7e391

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7fbe69d into tikv:master Nov 29, 2023
22 checks passed
@JmPotato JmPotato deleted the add_meta_http_client_test branch November 29, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp left review comments

@rleungx rleungx rleungx approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

Assignees
No one assigned
Labels
component/api HTTP API. component/client Client logic. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JmPotato @CabinfeverB @rleungx @HuSharp