-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/http: add GetHistoryHotRegions interface and more tests #7453
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7453 +/- ##
==========================================
+ Coverage 74.16% 74.36% +0.20%
==========================================
Files 451 451
Lines 49697 49714 +17
==========================================
+ Hits 36856 36970 +114
+ Misses 9521 9422 -99
- Partials 3320 3322 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
27a4a36
to
f62d10c
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
f62d10c
to
d961677
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
// WithAllowFollowerHandle sets the header field to allow a PD follower to handle this request. | ||
func WithAllowFollowerHandle() HeaderOption { | ||
return func(header http.Header) { | ||
header.Set("PD-Allow-Follower-Handle", "true") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use const for PD-Allow-Follower-Handle
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is only one constant right now, I think we can change it later when we introduce more.
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3d7e391
|
What problem does this PR solve?
Issue Number: ref #7300.
What is changed and how does it work?
Check List
Tests
Release note