Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add follower option #7465

Merged
merged 4 commits into from
Nov 29, 2023
Merged

client: add follower option #7465

merged 4 commits into from
Nov 29, 2023

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7431

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@CabinfeverB
add follower option
eb3da36 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2023
rleungx
rleungx reviewed Nov 28, 2023
View reviewed changes
client/client.go Outdated
@@ -211,6 +212,11 @@ func WithBuckets() GetRegionOption {
return func(op *GetRegionOp) { op.needBuckets = true }
}

// AllowFollowerHandle means that client can send request to follower and let it handle this request.
func AllowFollowerHandle() GetRegionOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping consistent with the HTTP interface and changing it to WithAllowFollowerHandle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gRPC uses lower case, but HTTP uses MIME format. So I think no need to keep consistent.

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #7465 (92ed72b) into master (90245e3) will increase coverage by 0.09%.
The diff coverage is 9.09%.

❗ Current head 92ed72b differs from pull request most recent head f4923bd. Consider uploading reports for the commit f4923bd to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7465      +/-   ##
==========================================
+ Coverage   74.16%   74.25%   +0.09%     
==========================================
  Files         451      451              
  Lines       49696    49698       +2     
==========================================
+ Hits        36855    36905      +50     
+ Misses       9521     9487      -34     
+ Partials     3320     3306      -14
Flag Coverage Δ
unittests 74.25% <9.09%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@CabinfeverB
address comment
92ed72b 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2023
HuSharp
HuSharp reviewed Nov 29, 2023
View reviewed changes
client/option.go Outdated
}
}

// getMaxTSOBatchWaitIntervalgets the Follower Handle enable option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// getMaxTSOBatchWaitIntervalgets the Follower Handle enable option.
// getMaxTSOBatchWaitInterval gets the Follower Handle enable option.

@CabinfeverB
address comment
79b0ba0 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 79b0ba0

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

@CabinfeverB: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1934450 into tikv:master Nov 29, 2023
22 checks passed
@CabinfeverB CabinfeverB mentioned this pull request Dec 28, 2023
Closed
3 tasks
@lidaohang
Copy link

mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CabinfeverB @lidaohang @lhy1024 @rleungx @HuSharp