-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: fix panic of get leader #7472
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7472 +/- ##
==========================================
- Coverage 74.46% 74.21% -0.26%
==========================================
Files 452 451 -1
Lines 49942 49728 -214
==========================================
- Hits 37190 36906 -284
- Misses 9412 9487 +75
+ Partials 3340 3335 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -149,13 +143,9 @@ func (m *Participant) GetLeaderID() uint64 { | |||
func (m *Participant) GetLeader() participant { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to cherry pick it?
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f82a0cd
|
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
/hold |
/hold cancel |
What problem does this PR solve?
Issue Number: Close #7280.
What is changed and how does it work?
Check List
Tests
Release note