Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: fix panic of get leader #7472

Merged
merged 2 commits into from
Dec 7, 2023
Merged

mcs: fix panic of get leader #7472

merged 2 commits into from
Dec 7, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 29, 2023

What problem does this PR solve?

Issue Number: Close #7280.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #7472 (f82a0cd) into master (995fcef) will decrease coverage by 0.26%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head f82a0cd differs from pull request most recent head e3d35c4. Consider uploading reports for the commit e3d35c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7472      +/-   ##
==========================================
- Coverage   74.46%   74.21%   -0.26%     
==========================================
  Files         452      451       -1     
  Lines       49942    49728     -214     
==========================================
- Hits        37190    36906     -284     
- Misses       9412     9487      +75     
+ Partials     3340     3335       -5     
Flag Coverage Δ
unittests 74.21% <100.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2023
@@ -149,13 +143,9 @@ func (m *Participant) GetLeaderID() uint64 {
func (m *Participant) GetLeader() participant {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to cherry pick it?

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2023
@rleungx
Copy link
Member Author

rleungx commented Dec 7, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f82a0cd

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2023
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CabinfeverB
Copy link
Member

/run-all-tests

@CabinfeverB
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@CabinfeverB
Copy link
Member

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit d8550f0 into tikv:master Dec 7, 2023
22 checks passed
@rleungx rleungx deleted the stable-test18 branch December 8, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: panic in TestRandomResignLeader
5 participants