Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove the tombstone store metrics #7504

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 7, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

After the store becomes tombstone, the metrics still exist. We should delete them as PD does. Our integration test relies on these metrics to determine if the stores are balanced.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and Yisaer December 7, 2023 03:58
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2023
@rleungx rleungx requested review from lhy1024 and CabinfeverB and removed request for Yisaer and HunDunDM December 7, 2023 04:01
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #7504 (3d28e97) into master (995fcef) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7504      +/-   ##
==========================================
+ Coverage   74.46%   74.59%   +0.12%     
==========================================
  Files         452      452              
  Lines       49942    49944       +2     
==========================================
+ Hits        37190    37254      +64     
+ Misses       9412     9368      -44     
+ Partials     3340     3322      -18     
Flag Coverage Δ
unittests 74.59% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2023
@rleungx
Copy link
Member Author

rleungx commented Dec 7, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3d28e97

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit ad232d1 into tikv:master Dec 7, 2023
27 checks passed
@rleungx rleungx deleted the remove-tombstone-metrics branch December 7, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants