-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove the tombstone store metrics #7504
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7504 +/- ##
==========================================
+ Coverage 74.46% 74.59% +0.12%
==========================================
Files 452 452
Lines 49942 49944 +2
==========================================
+ Hits 37190 37254 +64
+ Misses 9412 9368 -44
+ Partials 3340 3322 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3d28e97
|
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
After the store becomes tombstone, the metrics still exist. We should delete them as PD does. Our integration test relies on these metrics to determine if the stores are balanced.
Check List
Tests
Release note