Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: unify label name to group_name #7547

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 13, 2023

What problem does this PR solve?

Issue Number: Close #7546

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 13, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx December 13, 2023 11:53
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2023
Signed-off-by: nolouch <nolouch@gmail.com>
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #7547 (a4e6b94) into master (ebd2fc0) will increase coverage by 0.04%.
Report is 2 commits behind head on master.
The diff coverage is 60.71%.

❗ Current head a4e6b94 differs from pull request most recent head 3f1d841. Consider uploading reports for the commit 3f1d841 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7547      +/-   ##
==========================================
+ Coverage   74.73%   74.77%   +0.04%     
==========================================
  Files         457      457              
  Lines       50392    50392              
==========================================
+ Hits        37658    37681      +23     
+ Misses       9399     9376      -23     
  Partials     3335     3335              
Flag Coverage Δ
unittests 74.77% <60.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch nolouch requested review from CabinfeverB and HuSharp and removed request for JmPotato and rleungx December 20, 2023 06:24
@HuSharp
Copy link
Member

HuSharp commented Dec 20, 2023

can you paste a picture to indicate this PR's change is working?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2023
@nolouch
Copy link
Contributor Author

nolouch commented Dec 20, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a4e6b94

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 08296eb into tikv:master Dec 20, 2023
19 checks passed
@nolouch nolouch deleted the unify-metrics branch January 3, 2024 08:43
@nolouch nolouch added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 3, 2024
@nolouch
Copy link
Contributor Author

nolouch commented Jan 3, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7656.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 3, 2024
close #7546

Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the metrics label of resource control
5 participants