Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/api: replace client to pd http client #7574

Merged
merged 6 commits into from
Dec 22, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Dec 19, 2023

What problem does this PR solve?

Issue Number: ref #7300

What is changed and how does it work?

change tools/api client to HTTP SDK

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.
image

source in log is tools-api-bench

[2023/12/19 11:27:42.366 +08:00] [INFO] [client.go:315] ["[pd] http client members info changed"] [source=tools-api-bench] [old-member-num=1] [new-member-num=1] [old-addrs="[http://127.0.0.1:2379]"] [new-addrs="[http://127.0.0.1:2379]"] [old-leader-addr-idx=-1] [new-leader-addr-idx=0] [old-leader-addr=] [new-leader-addr=http://127.0.0.1:2379]

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 19, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unnecessary change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need exeute authority

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #7574 (0f8b4ca) into master (16e80d8) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7574      +/-   ##
==========================================
- Coverage   74.77%   74.74%   -0.03%     
==========================================
  Files         459      459              
  Lines       50552    50552              
==========================================
- Hits        37800    37786      -14     
- Misses       9407     9415       +8     
- Partials     3345     3351       +6     
Flag Coverage Δ
unittests 74.74% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@purelind
Copy link
Contributor

/test ?

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

@purelind: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

/test pull-integration-realcluster-test

@HuSharp
Copy link
Member Author

HuSharp commented Dec 21, 2023

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Member Author

HuSharp commented Dec 22, 2023

@CabinfeverB PTAL, thx!

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 22, 2023
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0f8b4ca

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit 07f7e78 into tikv:master Dec 22, 2023
26 checks passed
@HuSharp HuSharp deleted the replace_api_test branch December 22, 2023 09:02
@HuSharp HuSharp mentioned this pull request Jan 29, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants