-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/api: replace client to pd http client #7574
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tools/pd-api-bench/cert_opt.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unnecessary change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need exeute authority
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7574 +/- ##
==========================================
- Coverage 74.77% 74.74% -0.03%
==========================================
Files 459 459
Lines 50552 50552
==========================================
- Hits 37800 37786 -14
- Misses 9407 9415 +8
- Partials 3345 3351 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
30abd7e
to
bb8b1e7
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
/test ? |
@purelind: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-integration-realcluster-test |
/test pull-integration-realcluster-test |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@CabinfeverB PTAL, thx! |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 0f8b4ca
|
What problem does this PR solve?
Issue Number: ref #7300
What is changed and how does it work?
Check List
Tests
Release note
source in log is
tools-api-bench