client: rename follower handle var #7577
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
|
/test pull-integration-copr-test |
|
@CabinfeverB: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -707,12 +707,12 @@ func (c *client) UpdateOption(option DynamicOption, value interface{}) error { | |||
| return errors.New("[pd] invalid value type for EnableTSOFollowerProxy option, it should be bool") | |||
| } | |||
| c.option.setEnableTSOFollowerProxy(enable) | |||
| case EnableFollowerHandle: | |||
| case EnableFollowerHandleRegionRequest: | |||
There was a problem hiding this comment.
If we have more and more requests, will the option become bloated in the future?
There was a problem hiding this comment.
It'll be more, but I don't think it'll be bloated. If there are more options, we can provide a function to turn all options on or off, but we must be able to control them separately
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7577 +/- ##
=======================================
Coverage 74.79% 74.79%
=======================================
Files 459 459
Lines 50541 50541
=======================================
+ Hits 37802 37803 +1
+ Misses 9391 9387 -4
- Partials 3348 3351 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
After discussion, because there is only region api at present, and the variables of pd client are generally not directly exposed to users, we can not change it for the time being |
What problem does this PR solve?
Issue Number: ref #7431
What is changed and how does it work?
We need to clearly define the range of APIs that a follower handle can handle
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note