tests/realcluster: support local real cluster test #7578

HuSharp · 2023-12-19T09:35:28Z

What problem does this PR solve?

Issue Number: ref #7298

What is changed and how does it work?

tests/realcluster: support local real cluster test

Currently, we download the binaries via the ci repo PingCAP-QE/ci@main/pipelines/tikv/pd/latest/pull_integration_realcluster_test.groovy#L57- L65 in pd/bin to download the binary.

This approach reduces the cost of learning for developers. However, these packages can only be downloaded by the ci, which means that it is not possible to run locally.

To solve this problem, I would like to load the packages via tiup instead of downloading them by self.

Because for example, tiflash is a bit tricky to download packages
PingCAP-QE/ci@main/scripts/artifacts/download_pingcap_artifact.sh#L101

Check List

Tests

Integration test
Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot · 2023-12-19T09:35:31Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

HuSharp · 2023-12-19T09:36:35Z

/test pull-integration-realcluster-test

HuSharp · 2023-12-19T09:45:44Z

/test pull-integration-realcluster-test

codecov · 2023-12-19T09:50:18Z

Codecov Report

Merging #7578 (87095d6) into master (f15db4b) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 87095d6 differs from pull request most recent head 6f35718. Consider uploading reports for the commit 6f35718 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7578      +/-   ##
==========================================
+ Coverage   74.79%   74.82%   +0.03%     
==========================================
  Files         457      457              
  Lines       50415    50397      -18     
==========================================
+ Hits        37710    37712       +2     
+ Misses       9372     9356      -16     
+ Partials     3333     3329       -4

Flag	Coverage Δ
unittests	`74.82% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

HuSharp · 2023-12-19T11:35:23Z

/test pull-integration-realcluster-test

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-12-19T11:52:58Z

/test pull-integration-realcluster-test

tests/integrations/realtiup/deploy.sh

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-12-21T01:59:31Z

/test ?

ti-chi-bot · 2023-12-21T01:59:35Z

@HuSharp: The following commands are available to trigger required jobs:

/test build

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test
/test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HuSharp · 2023-12-21T01:59:56Z

/test pull-integration-realcluster-test

CabinfeverB · 2023-12-21T02:07:48Z

tests/integrations/realcluster/deploy.sh

+else
+  color-green "using existing binaries..."
+	$TIUP_BIN_DIR playground nightly --kv 3 --tiflash 1 --db 1 --pd 3 --without-monitor \
+		--pd.binpath ./bin/pd-server --kv.binpath ./bin/tikv-server --db.binpath ./bin/tidb-server --tiflash.binpath ./bin/tiflash --tag pd_test \


Does the user need to move tidb/tikv/tiflash binaries to the current bin path?

Currently, we download the binaries via the ci repo https://github.com/PingCAP-QE/ci/blob/main/pipelines/tikv/pd/latest/pull_integration_realcluster_test.groovy#L57- L65 in pd/bin to download the binary.

This approach reduces the cost of learning for developers. However, these packages can only be downloaded by the ci, which means that it is not possible to run locally.

To solve this problem, I would like to load the packages via tiup instead of downloading them by self.

Because for example, tiflash is a bit tricky to download packages
https://github.com/PingCAP-QE/ci/blob/main/scripts/artifacts/download_pingcap_artifact.sh#L101

maybe I can give more information in annotation, or do you have any advice? :)

I see. Maybe we provider some flags to specify bin paths for other components?

I'm not sure whether we need to support this feature
I think both methods start the test in essentially the same way?

cp binary file to directory

specific binpath flags

cc @JmPotato

Yes, It's both OK to me.

I think we could keep the current implementation since it's most used in the CI environment.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-12-21T02:51:59Z

/test pull-integration-realcluster-test

…rt_local_test

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-12-21T03:24:33Z

/test pull-integration-realcluster-test

HuSharp · 2023-12-21T03:31:58Z

/test pull-integration-realcluster-test 5

CabinfeverB · 2023-12-21T07:56:02Z

/merge

ti-chi-bot · 2023-12-21T07:56:04Z

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-12-21T07:56:06Z

This pull request has been accepted and is ready to merge.

Commit hash: 87095d6

ti-chi-bot · 2023-12-21T07:56:19Z

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

support local test

c1c0566

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 19, 2023

ti-chi-bot bot requested review from rleungx and Yisaer December 19, 2023 09:35

ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2023

HuSharp requested review from JmPotato and CabinfeverB and removed request for Yisaer and rleungx December 19, 2023 09:35

rename tiup

23685b9

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the support_local_test branch from ca21676 to 23685b9 Compare December 19, 2023 11:52

JmPotato reviewed Dec 20, 2023

View reviewed changes

tests/integrations/realtiup/deploy.sh Outdated Show resolved Hide resolved

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023

HuSharp added 2 commits December 21, 2023 09:58

Merge remote-tracking branch 'upstream/master' into support_local_test

e94b1a6

check all components

93fcfa1

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the support_local_test branch from 25b93d9 to 93fcfa1 Compare December 21, 2023 01:58

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 21, 2023

CabinfeverB reviewed Dec 21, 2023

View reviewed changes

add annotation

69ea471

Signed-off-by: husharp <jinhao.hu@pingcap.com>

add comment

7a77e32

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the support_local_test branch from 69ea471 to 7a77e32 Compare December 21, 2023 02:38

JmPotato approved these changes Dec 21, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2023

HuSharp added 2 commits December 21, 2023 11:19

Merge branch 'support_local_test' of github.com:HuSharp/pd into suppo…

786c681

…rt_local_test

fix test

87095d6

Signed-off-by: husharp <jinhao.hu@pingcap.com>

CabinfeverB approved these changes Dec 21, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2023

Merge branch 'master' into support_local_test

6f35718

ti-chi-bot bot merged commit f1870c1 into tikv:master Dec 21, 2023
22 checks passed

HuSharp deleted the support_local_test branch March 22, 2024 01:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests/realcluster: support local real cluster test #7578

tests/realcluster: support local real cluster test #7578

HuSharp commented Dec 19, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 19, 2023 •

edited

Loading

HuSharp commented Dec 19, 2023

HuSharp commented Dec 19, 2023

codecov bot commented Dec 19, 2023 •

edited

Loading

HuSharp commented Dec 19, 2023

HuSharp commented Dec 19, 2023

HuSharp commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

HuSharp commented Dec 21, 2023

CabinfeverB Dec 21, 2023 •

edited

Loading

HuSharp Dec 21, 2023

CabinfeverB Dec 21, 2023

HuSharp Dec 21, 2023 •

edited

Loading

CabinfeverB Dec 21, 2023

JmPotato Dec 21, 2023

HuSharp commented Dec 21, 2023

HuSharp commented Dec 21, 2023

HuSharp commented Dec 21, 2023

CabinfeverB commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

tests/realcluster: support local real cluster test #7578

tests/realcluster: support local real cluster test #7578

Conversation

HuSharp commented Dec 19, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Dec 19, 2023 • edited Loading

HuSharp commented Dec 19, 2023

HuSharp commented Dec 19, 2023

codecov bot commented Dec 19, 2023 • edited Loading

Codecov Report

HuSharp commented Dec 19, 2023

HuSharp commented Dec 19, 2023

HuSharp commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

HuSharp commented Dec 21, 2023

CabinfeverB Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

HuSharp Dec 21, 2023

Choose a reason for hiding this comment

CabinfeverB Dec 21, 2023

Choose a reason for hiding this comment

HuSharp Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

CabinfeverB Dec 21, 2023

Choose a reason for hiding this comment

JmPotato Dec 21, 2023

Choose a reason for hiding this comment

HuSharp commented Dec 21, 2023

HuSharp commented Dec 21, 2023

HuSharp commented Dec 21, 2023

CabinfeverB commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

HuSharp commented Dec 19, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 19, 2023 •

edited

Loading

codecov bot commented Dec 19, 2023 •

edited

Loading

CabinfeverB Dec 21, 2023 •

edited

Loading

HuSharp Dec 21, 2023 •

edited

Loading