Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add maxprocs metrics for mcs #7604

Merged
merged 8 commits into from
Dec 25, 2023
Merged

*: add maxprocs metrics for mcs #7604

merged 8 commits into from
Dec 25, 2023

Conversation

CabinfeverB
Copy link
Member

@CabinfeverB CabinfeverB commented Dec 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5839

What is changed and how does it work?

move pd_service_maxprocs into pkg/basicserver for mcs and pd server

Check List

Tests

  • Integration test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@CabinfeverB
add maxprocs for mcs
c782c88 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023
@CabinfeverB
add maxprocs for mcs
04d2793 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Merging #7604 (edc76b1) into master (b36b725) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7604      +/-   ##
==========================================
- Coverage   74.77%   74.71%   -0.07%     
==========================================
  Files         459      459              
  Lines       50577    50577              
==========================================
- Hits        37820    37789      -31     
- Misses       9402     9437      +35     
+ Partials     3355     3351       -4
Flag Coverage Δ
unittests 74.71% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Dec 21, 2023
View reviewed changes
pkg/basicserver/metrics.go Outdated
import "github.com/prometheus/client_golang/prometheus"

var (
ServerMaxProcs = prometheus.NewGauge(
Copy link
Member

@rleungx rleungx Dec 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also moving serverInfo here?

@CabinfeverB
address comment
9d29f91 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB CabinfeverB changed the title *: add maxprocs for mcs *: add maxprocs metrics for mcs Dec 21, 2023
@CabinfeverB
address comment
25692a8 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2023
@CabinfeverB CabinfeverB requested a review from lhy1024 December 22, 2023 03:13
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2023
rleungx
rleungx reviewed Dec 22, 2023
View reviewed changes
pkg/basicserver/metrics.go
})

// ServerInfoGauge indicates the pd server info including version and git hash.
ServerInfoGauge = prometheus.NewGaugeVec(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option, we can define the metrics for different services here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One metrics is maybe enough. We can get instance roles from service-role plane and find version info by instance.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 25, 2023
@CabinfeverB
merge master
07a7932 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
merge master
7f08896 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
merge master
d72fe60 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
merge master
edc76b1 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2023
@CabinfeverB
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: edc76b1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8950c3a into tikv:master Dec 25, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CabinfeverB @lhy1024 @rleungx