Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: support status api #7606

Merged
merged 3 commits into from
Dec 22, 2023
Merged

mcs: support status api #7606

merged 3 commits into from
Dec 22, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 21, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Support /status HTTP API.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #7606 (576856d) into master (74ef91d) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 576856d differs from pull request most recent head 52ec923. Consider uploading reports for the commit 52ec923 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7606      +/-   ##
==========================================
- Coverage   74.79%   74.68%   -0.12%     
==========================================
  Files         459      459              
  Lines       50541    50552      +11     
==========================================
- Hits        37802    37754      -48     
- Misses       9391     9437      +46     
- Partials     3348     3361      +13     
Flag Coverage Δ
unittests 74.68% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 22, 2023
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 576856d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@JmPotato
Copy link
Member

Need to fix the Check PD.

/unmerge

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2023
@rleungx
Copy link
Member Author

rleungx commented Dec 22, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c46aadf

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5d00faf into tikv:master Dec 22, 2023
22 checks passed
@rleungx rleungx deleted the add-status branch December 22, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants