metrics: add instance var and improve conccurrency metrics #7619

CabinfeverB · 2023-12-25T10:09:58Z

What problem does this PR solve?

Issue Number: close #7583

What is changed and how does it work?

add isntance var
add instance check for gRPC and HTTP
use max_over_time to keep conccurrency metrics same with qps

Check List

Tests

Manual test (add detailed scripts or steps below)

conccurrency

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot · 2023-12-25T10:10:00Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HuSharp
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-12-25T10:21:44Z

Codecov Report

Merging #7619 (894fd3e) into master (c3ad361) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7619      +/-   ##
==========================================
+ Coverage   73.72%   73.85%   +0.12%     
==========================================
  Files         429      429              
  Lines       47379    47379              
==========================================
+ Hits        34931    34992      +61     
+ Misses       9439     9394      -45     
+ Partials     3009     2993      -16

Flag	Coverage Δ
unittests	`73.85% <ø> (+0.12%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx · 2023-12-25T10:29:28Z

metrics/grafana/pd.json

@@ -132,7 +132,7 @@
      "tableColumn": "",
      "targets": [
        {
-          "expr": "sum(pd_cluster_status{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", type=\"storage_capacity\"})",
+          "expr": "max(pd_cluster_status{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", type=\"storage_capacity\"})",


If the original leader panics, and then offline a store, will the monitor always show the original value?

Got it. This PR will not close #7506

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB · 2024-01-04T13:49:25Z

cc @nolouch @HuSharp

CabinfeverB · 2024-01-08T02:59:00Z

/merge

ti-chi-bot · 2024-01-08T02:59:03Z

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-01-08T02:59:04Z

This pull request has been accepted and is ready to merge.

Commit hash: 894fd3e

close tikv#7583 Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Signed-off-by: pingandb <songge102@pingan.com.cn>

add instance var

397e857

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 25, 2023

ti-chi-bot bot requested review from JmPotato and lhy1024 December 25, 2023 10:10

ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 25, 2023

CabinfeverB requested review from rleungx and removed request for JmPotato December 25, 2023 10:10

rleungx reviewed Dec 25, 2023

View reviewed changes

only instance

682bfd1

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB mentioned this pull request Dec 28, 2023

Activate Follower-Handle #7431

Closed

3 tasks

CabinfeverB added 3 commits December 29, 2023 10:56

merge master

034bef1

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

fix

c6ec693

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

fix

ba4ef7e

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB requested review from nolouch and HuSharp January 2, 2024 03:29

rleungx approved these changes Jan 2, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 2, 2024

improve metrics

26898d8

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB changed the title ~~metrics: add instance var~~ metrics: add instance var and improve conccurrency metrics Jan 2, 2024

Merge branch 'master' into metrics/add_instance

894fd3e

HuSharp approved these changes Jan 8, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 8, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 8, 2024

ti-chi-bot bot merged commit 33a0d94 into tikv:master Jan 8, 2024
24 of 26 checks passed

pingandb pushed a commit to pingandb/pd that referenced this pull request Jan 18, 2024

metrics: add instance var and improve conccurrency metrics (tikv#7619)

3b8a4ca

close tikv#7583 Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Signed-off-by: pingandb <songge102@pingan.com.cn>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

metrics: add instance var and improve conccurrency metrics #7619

metrics: add instance var and improve conccurrency metrics #7619

CabinfeverB commented Dec 25, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 25, 2023 •

edited

Loading

codecov bot commented Dec 25, 2023 •

edited

Loading

rleungx Dec 25, 2023

CabinfeverB Dec 26, 2023

CabinfeverB commented Jan 4, 2024

CabinfeverB commented Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024

metrics: add instance var and improve conccurrency metrics #7619

metrics: add instance var and improve conccurrency metrics #7619

Conversation

CabinfeverB commented Dec 25, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Dec 25, 2023 • edited Loading

codecov bot commented Dec 25, 2023 • edited Loading

Codecov Report

rleungx Dec 25, 2023

Choose a reason for hiding this comment

CabinfeverB Dec 26, 2023

Choose a reason for hiding this comment

CabinfeverB commented Jan 4, 2024

CabinfeverB commented Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024

CabinfeverB commented Dec 25, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 25, 2023 •

edited

Loading

codecov bot commented Dec 25, 2023 •

edited

Loading