Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_group: don't accumulate tokens when burstlimit less than 0 #7626

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

CabinfeverB
Copy link
Member

@CabinfeverB CabinfeverB commented Dec 27, 2023

What problem does this PR solve?

Issue Number: ref #7206

What is changed and how does it work?

We can find a large number from default resource group.

{"r_u":{"settings":{"fill_rate":2147483647,"burst_limit":-1},"state":{"tokens":29860685960413220,"last_update":"2023-12-27T08:19:16.269363735Z","initialized":true}}}

So don't accumulate tokens when burstlimit less than 0

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 27, 2023
@CabinfeverB CabinfeverB removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 27, 2023
@CabinfeverB CabinfeverB requested review from nolouch and bufferflies and removed request for HunDunDM and rleungx December 27, 2023 09:11
@CabinfeverB
Copy link
Member Author

@nolouch do we need cherry-pick?

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #7626 (4c4ad7c) into master (baf4345) will decrease coverage by 0.08%.
The diff coverage is 90.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
- Coverage   73.89%   73.82%   -0.08%     
==========================================
  Files         429      429              
  Lines       47345    47346       +1     
==========================================
- Hits        34986    34953      -33     
- Misses       9368     9399      +31     
- Partials     2991     2994       +3     
Flag Coverage Δ
unittests 73.82% <90.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 27, 2023
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 2, 2024
@nolouch
Copy link
Contributor

nolouch commented Jan 2, 2024

@nolouch do we need cherry-pick?

Yes, I think we need.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 3, 2024
@nolouch
Copy link
Contributor

nolouch commented Jan 3, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

This pull request has been accepted and is ready to merge.

Commit hash: da29fb5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit a4d2f1c into tikv:master Jan 3, 2024
25 of 26 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7657.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7658.

ti-chi-bot bot added a commit that referenced this pull request Jan 4, 2024
…7626) (#7658)

ref #7206

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jan 4, 2024
…7626) (#7657)

ref #7206

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
pingandb pushed a commit to pingandb/pd that referenced this pull request Jan 18, 2024
…ikv#7626)

ref tikv#7206

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants