-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: directly save tls config #7662
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
client/client.go
Outdated
@@ -358,7 +359,7 @@ func createClientWithKeyspace( | |||
ctx context.Context, keyspaceID uint32, svrAddrs []string, | |||
security SecurityOption, opts ...ClientOption, | |||
) (Client, error) { | |||
tlsCfg := &tlsutil.TLSConfig{ | |||
pdTlsCfg := &tlsutil.TLSConfig{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
tlsCfg, err := &tlsutil.TLSConfig{...}.ToTLSConfig()
?
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7662 +/- ##
==========================================
- Coverage 73.87% 73.76% -0.11%
==========================================
Files 429 429
Lines 47376 47379 +3
==========================================
- Hits 35000 34951 -49
- Misses 9392 9428 +36
- Partials 2984 3000 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 120728c
|
ref tikv#7576 Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: pingandb <songge102@pingan.com.cn>
What problem does this PR solve?
Issue Number: ref #7576
What is changed and how does it work?
no need to transfer
TLSConfig
totls.Config
.And after replacing it, we can check whether use tls more expediently.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note