scheduler: add aduit log for scheduler config API and add resp msg for evict-leader #7674

CabinfeverB · 2024-01-08T03:29:54Z

What problem does this PR solve?

Issue Number: Close #7672

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

[2024/01/08 11:20:31.719 +08:00] [INFO] [audit.go:126] ["audit log"] [service-info="{ServiceLabel:HandleSchedulerConfig, Method:HTTP/1.1/DELETE:/pd/api/v1/scheduler-config/evict-leader-scheduler/delete/2, CallerID:pd-ctl, IP:127.0.0.1 , Port:58671, StartTime:2024-01-08 11:20:31 +0800 CST, URLParam:{}, BodyParam:}"]
[2024/01/08 11:21:06.896 +08:00] [INFO] [audit.go:126] ["audit log"] [service-info="{ServiceLabel:HandleSchedulerConfig, Method:HTTP/1.1/POST:/pd/api/v1/scheduler-config/evict-leader-scheduler/config, CallerID:pd-ctl, IP:127.0.0.1, Po rt:58851, StartTime:2024-01-08 11:21:06 +0800 CST, URLParam:{}, BodyParam:{"name":"evict-leader-scheduler","store_id":2}}"]
Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot · 2024-01-08T03:29:56Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

rleungx · 2024-01-09T07:19:33Z

server/api/router.go

@@ -151,7 +151,8 @@ func createRouter(prefix string, svr *server.Server) *mux.Router {
 	registerFunc(clusterRouter, "/schedulers/diagnostic/{name}", diagnosticHandler.GetDiagnosticResult, setMethods(http.MethodGet), setAuditBackend(prometheus))

 	schedulerConfigHandler := newSchedulerConfigHandler(svr, rd)
-	registerPrefix(apiRouter, "/scheduler-config", schedulerConfigHandler.GetSchedulerConfig, setAuditBackend(prometheus))
+	registerPrefix(apiRouter, "/scheduler-config", "HandleSchedulerConfig", schedulerConfigHandler.HandleSchedulerConfig, setMethods(http.MethodPost, http.MethodDelete, http.MethodPut, http.MethodPatch), setAuditBackend(localLog, prometheus))


How about SetSchedulerConfig?

It also includes the deletion method.

nolouch · 2024-01-09T14:57:49Z

/merge

ti-chi-bot · 2024-01-09T14:57:51Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-01-09T14:57:53Z

This pull request has been accepted and is ready to merge.

Commit hash: bc10409

codecov · 2024-01-09T15:09:00Z

Codecov Report

Merging #7674 (b934f31) into master (dd8df25) will increase coverage by 0.10%.
The diff coverage is 66.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7674      +/-   ##
==========================================
+ Coverage   73.56%   73.66%   +0.10%     
==========================================
  Files         429      429              
  Lines       47434    47435       +1     
==========================================
+ Hits        34893    34944      +51     
+ Misses       9560     9519      -41     
+ Partials     2981     2972       -9

Flag	Coverage Δ
unittests	`73.66% <66.66%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ti-chi-bot · 2024-01-09T15:10:24Z

In response to a cherrypick label: new pull request created to branch release-6.5: #7686.

close tikv#7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-01-09T15:11:03Z

In response to a cherrypick label: new pull request created to branch release-7.1: #7687.

ti-chi-bot · 2024-01-09T15:11:41Z

In response to a cherrypick label: new pull request created to branch release-7.5: #7688.

close tikv#7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

…r evict-leader (#7674) (#7686) close #7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com> Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>

…r evict-leader (#7674) (#7688) close #7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com> Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

…r evict-leader (#7674) (#7687) close #7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com> Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

…r evict-leader (tikv#7674) close tikv#7672 Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: pingandb <songge102@pingan.com.cn>

CabinfeverB added 3 commits January 8, 2024 10:09

fix

1f8f260

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

fix

dba2bf8

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

fix

d476dbb

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot requested review from HunDunDM and nolouch January 8, 2024 03:30

ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2024

CabinfeverB requested review from JmPotato, rleungx and HuSharp and removed request for HunDunDM January 8, 2024 03:30

CabinfeverB changed the title ~~scheduler: add aduit log for config API and add resp msg for evict-leader~~ scheduler: add aduit log for scheduler config API and add resp msg for evict-leader Jan 8, 2024

fix test

bc10409

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2024

rleungx reviewed Jan 9, 2024

View reviewed changes

rleungx approved these changes Jan 9, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 9, 2024

nolouch approved these changes Jan 9, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 9, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 9, 2024

Merge branch 'master' into fix_scheduler_api

b934f31

ti-chi-bot bot merged commit 8b8c78a into tikv:master Jan 9, 2024
23 of 26 checks passed

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 9, 2024

This is an automated cherry-pick of tikv#7674

100192b

close tikv#7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jan 9, 2024

scheduler: add aduit log for scheduler config API and add resp msg for evict-leader (#7674) #7686

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 9, 2024

This is an automated cherry-pick of tikv#7674

cae3b44

close tikv#7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jan 9, 2024

scheduler: add aduit log for scheduler config API and add resp msg for evict-leader (#7674) #7687

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 9, 2024

This is an automated cherry-pick of tikv#7674

56045ac

close tikv#7672 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jan 9, 2024

scheduler: add aduit log for scheduler config API and add resp msg for evict-leader (#7674) #7688

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scheduler: add aduit log for scheduler config API and add resp msg for evict-leader #7674

scheduler: add aduit log for scheduler config API and add resp msg for evict-leader #7674

CabinfeverB commented Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024 •

edited

Loading

rleungx Jan 9, 2024

CabinfeverB Jan 9, 2024

rleungx Jan 9, 2024

nolouch commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

codecov bot commented Jan 9, 2024

ti-chi-bot commented Jan 9, 2024

ti-chi-bot commented Jan 9, 2024

ti-chi-bot commented Jan 9, 2024

scheduler: add aduit log for scheduler config API and add resp msg for evict-leader #7674

scheduler: add aduit log for scheduler config API and add resp msg for evict-leader #7674

Conversation

CabinfeverB commented Jan 8, 2024

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Jan 8, 2024 • edited Loading

rleungx Jan 9, 2024

Choose a reason for hiding this comment

CabinfeverB Jan 9, 2024

Choose a reason for hiding this comment

rleungx Jan 9, 2024

Choose a reason for hiding this comment

nolouch commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

codecov bot commented Jan 9, 2024

Codecov Report

ti-chi-bot commented Jan 9, 2024

ti-chi-bot commented Jan 9, 2024

ti-chi-bot commented Jan 9, 2024

ti-chi-bot bot commented Jan 8, 2024 •

edited

Loading