client/http, retry: support backoffer in HTTP client #7680

JmPotato · 2024-01-08T05:19:00Z

What problem does this PR solve?

Issue Number: ref #7300, #7673.

What is changed and how does it work?

Support backoffer in HTTP client.

Check List

Tests

Unit test
Integration test

Release note

None.

ti-chi-bot · 2024-01-08T05:19:02Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HuSharp
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

client/http/client.go

codecov · 2024-01-08T05:38:37Z

Codecov Report

Merging #7680 (cd119aa) into master (c3ad361) will decrease coverage by 0.14%.
Report is 4 commits behind head on master.
The diff coverage is 91.26%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7680      +/-   ##
==========================================
- Coverage   73.72%   73.59%   -0.14%     
==========================================
  Files         429      429              
  Lines       47379    47433      +54     
==========================================
- Hits        34931    34909      -22     
- Misses       9439     9541     +102     
+ Partials     3009     2983      -26

Flag	Coverage Δ
unittests	`73.59% <91.26%> (-0.14%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lance6716

rest lgtm

lance6716 · 2024-01-08T05:53:09Z

client/http/interface.go

@@ -92,6 +93,8 @@ type Client interface {
 	// Additionally, it is important for the caller to handle the content of the response body properly
 	// in order to ensure that it can be read and marshaled correctly into `res`.
 	WithRespHandler(func(resp *http.Response, res interface{}) error) Client
+	// WithBackoffer sets and returns a new client with the given backoffer.
+	WithBackoffer(*retry.Backoffer) Client


I prefer caller use ClientOption in NewClient to set it.

Using WithBackoffer here allows us to flexibly use different Backoffers for different scenarios and interfaces like:

cli := NewClient() cli.WithBackoffer(bo1).GetRegion() cli.WithBackoffer(bo2).GetStore()

If we useClientOption for initialization, we may need to create a new Client every time we want to use a different Backoffer.

ti-chi-bot · 2024-01-08T06:01:32Z

@lance6716: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

client/retry/backoff.go

client/http/client.go

Signed-off-by: JmPotato <ghzpotato@gmail.com>

client/retry/backoff.go

rleungx

The rest LGTM

Signed-off-by: JmPotato <ghzpotato@gmail.com>

client/retry/backoff.go

JmPotato · 2024-01-09T07:27:07Z

/merge

ti-chi-bot · 2024-01-09T07:27:10Z

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-01-09T07:27:12Z

This pull request has been accepted and is ready to merge.

Commit hash: cd119aa

ref tikv#7300 Support backoffer in HTTP client. Signed-off-by: JmPotato <ghzpotato@gmail.com> Signed-off-by: pingandb <songge102@pingan.com.cn>

ref tikv#7300 Support backoffer in HTTP client. Signed-off-by: JmPotato <ghzpotato@gmail.com>

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 8, 2024

JmPotato requested review from rleungx and HuSharp January 8, 2024 05:19

ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2024

JmPotato added component/client Client logic. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2024

HuSharp reviewed Jan 8, 2024

View reviewed changes

client/http/client.go Show resolved Hide resolved

lance6716 reviewed Jan 8, 2024

View reviewed changes

lance6716 approved these changes Jan 8, 2024

View reviewed changes

ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2024

JmPotato force-pushed the add_backoffer_to_http_cli branch 3 times, most recently from f539e0f to 63884b9 Compare January 8, 2024 06:53

HuSharp reviewed Jan 8, 2024

View reviewed changes

client/retry/backoff.go Show resolved Hide resolved

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2024

JmPotato requested a review from HuSharp January 8, 2024 07:20

HuSharp approved these changes Jan 8, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 8, 2024

rleungx reviewed Jan 9, 2024

View reviewed changes

client/http/client.go Outdated Show resolved Hide resolved

JmPotato requested a review from rleungx January 9, 2024 05:27

JmPotato added 5 commits January 9, 2024 13:30

Support backoffer in HTTP client

84bc7f2

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Add more check to Backoffer

6820c65

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Add more tests

824f859

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Address the comment and add tests

fc796c4

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Remove unnecessary WithBackoffer(nil)

47826a8

Signed-off-by: JmPotato <ghzpotato@gmail.com>

rleungx reviewed Jan 9, 2024

View reviewed changes

client/retry/backoff.go Outdated Show resolved Hide resolved

rleungx reviewed Jan 9, 2024

View reviewed changes

Refine the retryable error check

cd119aa

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato force-pushed the add_backoffer_to_http_cli branch from 2867a9f to cd119aa Compare January 9, 2024 06:45

rleungx reviewed Jan 9, 2024

View reviewed changes

client/retry/backoff.go Show resolved Hide resolved

rleungx approved these changes Jan 9, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 9, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 9, 2024

ti-chi-bot bot merged commit f18de09 into tikv:master Jan 9, 2024
25 of 26 checks passed

JmPotato deleted the add_backoffer_to_http_cli branch January 9, 2024 07:41

JmPotato added a commit to JmPotato/pd that referenced this pull request Jan 25, 2024

client/http, retry: support backoffer in HTTP client (tikv#7680)

b94e74e

ref tikv#7300 Support backoffer in HTTP client. Signed-off-by: JmPotato <ghzpotato@gmail.com>

HuSharp mentioned this pull request Jan 29, 2024

Tracking issue for the HTTP SDK #7300

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client/http, retry: support backoffer in HTTP client #7680

client/http, retry: support backoffer in HTTP client #7680

JmPotato commented Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024 •

edited

Loading

codecov bot commented Jan 8, 2024 •

edited

Loading

lance6716 left a comment

lance6716 Jan 8, 2024

JmPotato Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024

rleungx left a comment

JmPotato commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

client/http, retry: support backoffer in HTTP client #7680

client/http, retry: support backoffer in HTTP client #7680

Conversation

JmPotato commented Jan 8, 2024

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Jan 8, 2024 • edited Loading

codecov bot commented Jan 8, 2024 • edited Loading

Codecov Report

lance6716 left a comment

Choose a reason for hiding this comment

lance6716 Jan 8, 2024

Choose a reason for hiding this comment

JmPotato Jan 8, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Jan 8, 2024

rleungx left a comment

Choose a reason for hiding this comment

JmPotato commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

ti-chi-bot bot commented Jan 9, 2024

ti-chi-bot bot commented Jan 8, 2024 •

edited

Loading

codecov bot commented Jan 8, 2024 •

edited

Loading