Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: init NewDefaultPDServiceDiscovery and refine http client tests #7744

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jan 22, 2024

What problem does this PR solve?

Issue Number: Close #7721

What is changed and how does it work?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 22, 2024
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx January 22, 2024 05:50
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 22, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jan 22, 2024

/test ?

Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2024

@HuSharp: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Member Author

HuSharp commented Jan 22, 2024

/test pull-integration-realcluster-test

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Member Author

HuSharp commented Jan 22, 2024

/test pull-integration-realcluster-test

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Merging #7744 (680a92c) into master (2c8e21c) will decrease coverage by 0.68%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7744      +/-   ##
==========================================
- Coverage   73.84%   73.16%   -0.68%     
==========================================
  Files         430      430              
  Lines       47629    47630       +1     
==========================================
- Hits        35173    34850     -323     
- Misses       9487     9814     +327     
+ Partials     2969     2966       -3     
Flag Coverage Δ
unittests 73.16% <75.00%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Member Author

HuSharp commented Jan 22, 2024

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 22, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Member Author

HuSharp commented Jan 22, 2024

/test pull-integration-realcluster-test

@HuSharp HuSharp requested a review from rleungx January 22, 2024 09:14
Signed-off-by: husharp <jinhao.hu@pingcap.com>
tests/integrations/realcluster/Makefile Show resolved Hide resolved
client/http/client.go Outdated Show resolved Hide resolved
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp requested a review from JmPotato January 23, 2024 02:53
@JmPotato
Copy link
Member

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 23, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jan 23, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 287d209

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b27b1e9 into tikv:master Jan 23, 2024
25 of 26 checks passed
@HuSharp HuSharp deleted the fix_pdcli_discovery branch January 23, 2024 07:01
@HuSharp HuSharp mentioned this pull request Jan 29, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
3 participants