Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: add leader verify in balance-region scheduler (#2966) #7803

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Feb 5, 2024

What problem does this PR solve?

Issue Number: ref #2966.

What is changed and how does it work?

Check region leader before balance region. If it has no leader, the balance for this region would be skipped.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 5, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx February 5, 2024 02:05
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 5, 2024
@JmPotato JmPotato merged commit c283b02 into tikv:release-4.0-20240205-v4.0.6 Feb 5, 2024
2 of 4 checks passed
@JmPotato JmPotato deleted the release-4.0-20240205-v4.0.6 branch February 5, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants