Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: wait until API server is ready #7814

Merged
merged 3 commits into from
Feb 9, 2024
Merged

mcs: wait until API server is ready #7814

merged 3 commits into from
Feb 9, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 8, 2024

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

TSO and scheduling server should keep waiting until the API server is ready.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 8, 2024
@rleungx rleungx changed the title mcs: wait until api server is ready mcs: wait until API server is ready Feb 8, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and Yisaer February 8, 2024 03:14
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
@rleungx rleungx requested review from HuSharp and removed request for Yisaer February 8, 2024 03:14
Comment on lines -138 to -140
if err != nil {
log.Warn("failed to check api server ready", errs.ZapError(err))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about print warn log every 60 seconds or another better time?
I'm worried that all are debug logs won't be easy to find root case such as when the wrong api addr is set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Merging #7814 (bf013b5) into master (3965b4c) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 40.00%.

❗ Current head bf013b5 differs from pull request most recent head e03a75a. Consider uploading reports for the commit e03a75a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7814      +/-   ##
==========================================
+ Coverage   73.44%   73.51%   +0.07%     
==========================================
  Files         432      432              
  Lines       47860    47879      +19     
==========================================
+ Hits        35150    35199      +49     
+ Misses       9665     9637      -28     
+ Partials     3045     3043       -2     
Flag Coverage Δ
unittests 73.51% <40.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2024
@rleungx
Copy link
Member Author

rleungx commented Feb 9, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 9, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 9, 2024

This pull request has been accepted and is ready to merge.

Commit hash: bf013b5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 9, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5e18408 into tikv:master Feb 9, 2024
22 checks passed
@rleungx rleungx deleted the wait branch February 9, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants