Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add config api for tso service #7858

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 29, 2024

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

This PR adds a config API so that TiDB can use query to get the config of the TSO server.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 29, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch February 29, 2024 07:03
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 29, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #7858 (533e48b) into master (e199866) will decrease coverage by 0.07%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 533e48b differs from pull request most recent head 590a576. Consider uploading reports for the commit 590a576 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7858      +/-   ##
==========================================
- Coverage   73.52%   73.46%   -0.07%     
==========================================
  Files         432      432              
  Lines       47937    47958      +21     
==========================================
- Hits        35248    35230      -18     
- Misses       9650     9688      +38     
- Partials     3039     3040       +1     
Flag Coverage Δ
unittests 73.46% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from JmPotato and CabinfeverB and removed request for nolouch February 29, 2024 07:21
// @Success 200 {object} server.Config
// @Router /config [get]
func getConfig(c *gin.Context) {
svr := c.MustGet(multiservicesapi.ServiceContextKey).(*tsoserver.Service)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to panic here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem we need to use Get?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think it barely happens.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 29, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 76b3279

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 2e3e4c0 into tikv:master Feb 29, 2024
22 checks passed
@rleungx rleungx deleted the tso-config-router branch February 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants