-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/tso: double-check the contexts to prevent waiting for TSO requests in closed chan #7962
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold |
023828a
to
7090582
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7962 +/- ##
==========================================
+ Coverage 73.54% 73.57% +0.03%
==========================================
Files 436 436
Lines 48432 48451 +19
==========================================
+ Hits 35618 35650 +32
+ Misses 9754 9740 -14
- Partials 3060 3061 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
I'm not sure if this is effective in avoiding blocks, but the code itself is fine with me. I suggest we can test it before we consider merging? |
I have manually tested it, and with this PR version of PD client, TiDB will no longer encounter the TSO hang issue. |
@@ -64,6 +63,13 @@ var tsoReqPool = sync.Pool{ | |||
}, | |||
} | |||
|
|||
func (req *tsoRequest) tryDone(err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need to try? from the goroutine profile we can make sure here is no blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A request may be revoked right after it is sent to tsoBatchController
, then if we double-check the contexts and return an error, done <- err
will be blocked.
…ed chan Signed-off-by: JmPotato <ghzpotato@gmail.com>
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 59c3a65
|
close tikv#7849 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #7849.
What is changed and how does it work?
Check List
Tests
Release note