tests/api: refine TestPreparingProgress to make test stable

[HuSharp]

What problem does this PR solve?

Issue Number: Ref #7969

What is changed and how does it work?

Because TestPreparingProgress mixes cluster prepare(3s per tick) and checkStores

• scheduler prepare (3s per tick)

  pd/pkg/schedule/coordinator.go

  Lines 402 to 419 in 945e29c

  	ticker := time.NewTicker(runSchedulerCheckInterval)
  	failpoint.Inject("changeCoordinatorTicker", func() {
  	ticker = time.NewTicker(100 * time.Millisecond)
  	})
  	defer ticker.Stop()
  	log.Info("coordinator starts to collect cluster information")
  	for {
  	if c.ShouldRun(collectWaitTime...) {
  	log.Info("coordinator has finished cluster information preparation")
  	break
  	}
  	select {
  	case <-ticker.C:
  	case <-c.ctx.Done():
  	log.Info("coordinator stops running")
  	return
  	}
  	}

• checkStores(2s per tick)
  

  pd/server/cluster/cluster.go

  Lines 676 to 696 in 945e29c

  	func (c *RaftCluster) runNodeStateCheckJob() {
  	defer logutil.LogPanic()
  	defer c.wg.Done()
  	ticker := time.NewTicker(nodeStateCheckJobInterval)
  	failpoint.Inject("highFrequencyClusterJobs", func() {
  	ticker.Stop()
  	ticker = time.NewTicker(2 * time.Second)
  	})
  	defer ticker.Stop()
  	for {
  	select {
  	case <-c.ctx.Done():
  	log.Info("node state check job has been stopped")
  	return
  	case <-ticker.C:
  	c.checkStores()
  	}
  	}
  	}

• If sleep 2s directly(which wants to wait for checkStores tick maybe mixed cluster prepare & checkStores, which will make test unstable.
  

  pd/tests/server/api/api_test.go

  Lines 936 to 945 in cd0ffba

  	// is not prepared
  	time.Sleep(2 * time.Second)
  	output = sendRequest(re, leader.GetAddr()+"/pd/api/v1/stores/progress?action=preparing", http.MethodGet, http.StatusNotFound)
  	re.Contains((string(output)), "no progress found for the action")
  	output = sendRequest(re, leader.GetAddr()+"/pd/api/v1/stores/progress?id=4", http.MethodGet, http.StatusNotFound)
  	re.Contains((string(output)), "no progress found for the given store ID")
  	// size is not changed.
  	leader.GetRaftCluster().SetPrepared()
  	time.Sleep(2 * time.Second)

So I have changed to eventually.

Check List

Tests

• Integration test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lhy1024
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #8014 (f6616a3) into master (67461dd) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head f6616a3 differs from pull request most recent head 7b3e56c. Consider uploading reports for the commit 7b3e56c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8014      +/-   ##
==========================================
- Coverage   77.27%   77.23%   -0.05%     
==========================================
  Files         468      468              
  Lines       60890    60869      -21     
==========================================
- Hits        47055    47012      -43     
- Misses      10291    10307      +16     
- Partials     3544     3550       +6     

Flag	Coverage Δ
unittests	77.23% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[HuSharp]

/hold

[HuSharp]

/unhold

[rleungx]

Do we need them since line 782 is return true?

[HuSharp]

• If enter the if judgment at line 782, then return at line 792. Then there's still a chance that we didn't prepare, so we need to wait for prepare to finish.
• The previous Eventually（line 782-798） is actually a judgment for not preparing.

[rleungx]

got

[rleungx]

The rest LGTM

[HuSharp]

/merge

[ti-chi-bot]

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 7b3e56c