tests/rule: make TestLargeRules more stable

[HuSharp]

What problem does this PR solve?

Issue Number: Ref #7969

What is changed and how does it work?

tested by #7969
Because below code will add default rule after the previous test finished, we need to skip default rule for large rule test to make it stable

pd/tests/server/api/rule_test.go

Lines 62 to 78 in 7e95abf

	func (suite *ruleTestSuite) TearDownTest() {
	re := suite.Require()
	cleanFunc := func(cluster *tests.TestCluster) {
	def := placement.GroupBundle{
	ID: "pd",
	Rules: []*placement.Rule{
	{GroupID: "pd", ID: "default", Role: "voter", Count: 3},
	},
	}
	data, err := json.Marshal([]placement.GroupBundle{def})
	re.NoError(err)
	urlPrefix := cluster.GetLeaderServer().GetAddr()
	err = tu.CheckPostJSON(testDialClient, urlPrefix+"/pd/api/v1/config/placement-rule", data, tu.StatusOK(re))
	re.NoError(err)
	}
	suite.env.RunFuncInTwoModes(cleanFunc)
	}

will

Check List

Tests

• Unit test
• Integration test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[rleungx]

Is there any error stack?

[HuSharp]

Is there any error stack?

This condition will never be met, I printed respBundle which has one more default value {GroupID: "pd", ID: "default", Role: "voter", Count: 3} than resp (this default value is added by TearDownTest`)
(

pd/tests/server/api/rule_test.go

Lines 1271 to 1273 in 7e95abf

	if len(respBundle) != len(bundle) {
	return false
	}

)

[rleungx]

Will it affect TestDeleteAndUpdate?

[nolouch]

will add default rule after the previous test finished

Why does it happen? Does it share the same environment?

[HuSharp]

will add default rule after the previous test finished

Why does it happen? Does it share the same environment?

yes, this suite test build env firstly and then using TearDownTest to clean up placement rules

pd/tests/server/api/rule_test.go

Lines 51 to 56 in 7e18a69

	func (suite *ruleTestSuite) SetupSuite() {
	suite.env = tests.NewSchedulingTestEnvironment(suite.T(), func(conf *config.Config, _ string) {
	conf.PDServerCfg.KeyType = "raw"
	conf.Replication.EnablePlacementRules = true
	})
	}

[HuSharp]

/hold

meet other issues need to be fixed

[HuSharp]

Root cause is

• ruleTestSuite has run some heavy load tests and reusing the same environment
• we run suiteTest just by 1 CPU resulting in the cluster maybe meeting leader transfer during the whole suite test
• I have allocated suiteTest more resources to avoid unnecessary error https://github.com/tikv/pd/pull/7991/files#diff-d1de7e6511458d33a769c0c501ec0ea45494dd9d2e830dc315e8fe623eb34b76R594-R598

So, we can close this pr now :)