Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: introduce RPCClient #8048

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: ref #8047

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB CabinfeverB requested a review from rleungx April 10, 2024 03:30
Copy link
Contributor

ti-chi-bot bot commented Apr 10, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 10, 2024
@CabinfeverB CabinfeverB requested review from HuSharp and JmPotato April 10, 2024 03:30
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #8048 (b165d37) into master (f0eb74b) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head b165d37 differs from pull request most recent head 39c622b. Consider uploading reports for the commit 39c622b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8048      +/-   ##
==========================================
+ Coverage   77.24%   77.32%   +0.07%     
==========================================
  Files         468      468              
  Lines       60879    60867      -12     
==========================================
+ Hits        47024    47063      +39     
+ Misses      10304    10264      -40     
+ Partials     3551     3540      -11     
Flag Coverage Δ
unittests 77.32% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2024
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 11, 2024
@nolouch
Copy link
Contributor

nolouch commented Apr 11, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

This pull request has been accepted and is ready to merge.

Commit hash: b165d37

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

@CabinfeverB: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 67461dd into tikv:master Apr 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants