Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make TestTSOKeyspaceGroupSplitElection stable #8110

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 22, 2024

What problem does this PR solve?

Issue Number: Close #8099

What is changed and how does it work?

The groupSplitPatroller may run immediately after the split request is finished. Then the check may fail since the split is finished.

Check List

Tests

  • Unit test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Apr 22, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch April 22, 2024 02:55
@rleungx rleungx changed the title *make TestTSOKeyspaceGroupSplitElection stable *: make TestTSOKeyspaceGroupSplitElection stable Apr 22, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 22, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx requested a review from HuSharp April 22, 2024 02:59
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Merging #8110 (9a188d1) into master (882d2e5) will increase coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8110      +/-   ##
==========================================
+ Coverage   77.28%   77.30%   +0.02%     
==========================================
  Files         470      470              
  Lines       61129    61143      +14     
==========================================
+ Hits        47244    47269      +25     
+ Misses      10310    10306       -4     
+ Partials     3575     3568       -7     
Flag Coverage Δ
unittests 77.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 22, 2024
@rleungx
Copy link
Member Author

rleungx commented Apr 22, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9a188d1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2f85f1f into tikv:master Apr 22, 2024
26 checks passed
@rleungx rleungx deleted the fix-test-2024-20 branch April 22, 2024 06:36
nolouch pushed a commit to nolouch/pd that referenced this pull request Apr 29, 2024
close tikv#8099

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test TestTSOKeyspaceGroupSplitElection
3 participants